[GitHub] [incubator-doris] morningman commented on a change in pull request #2891: Some tiny refactor on streaming-load related code

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2891: Some tiny refactor on streaming-load related code
URL: https://github.com/apache/incubator-doris/pull/2891#discussion_r378270366
 
 

 ##########
 File path: be/src/olap/memtable_flush_executor.cpp
 ##########
 @@ -42,7 +44,7 @@ OLAPStatus FlushHandler::wait() {
     return _last_flush_status.load();
 }
 
-void FlushHandler::on_flush_finished(const FlushResult& res) {
+void FlushHandler::_on_flush_finished(const FlushResult& res) {
 
 Review comment:
   Those `on_xxx` methods of `FlushHandler` should be public. FlushHandler is independent of MemTableFlushExecutor. Just because FlushHandler is a friend class of MemTableFlushExecutor, so that you can change it to private.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org