You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/09 13:16:06 UTC

[GitHub] [flink] godfreyhe commented on pull request #14516: [FLINK-20783][table-planner-blink] Separate implementation of ExecNode and PhysicalNode in batch join

godfreyhe commented on pull request #14516:
URL: https://github.com/apache/flink/pull/14516#issuecomment-757177059


   Thanks for the update. LGTM overall, one minor comment: we could also use SortSpec in `ComparatorCodeGenerator`, and please fix the compile error


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org