[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19676: [v1.x] Make ONNX export operators work properly with the node input shape

[GitBox <gi...@apache.org>]

Zha0q1 commented on a change in pull request #19676:
URL: https://github.com/apache/incubator-mxnet/pull/19676#discussion_r543687597



##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -91,9 +91,11 @@ def test_onnx_export_zeros_like(tmp_path):
 
 
 @pytest.mark.parametrize("dtype", ["float32", "float64"])
-def test_onnx_export_arange_like(tmp_path, dtype):
-    M = def_model('contrib.arange_like')
-    x = mx.nd.array([[-2,-1,0],[0,50,99],[4,5,6],[7,8,9]], dtype=dtype)
+@pytest.mark.parametrize("axis", [0,1,None])
+@pytest.mark.parametrize("test_data", [[[[0,1,2],[3,4,5]],[[6,7,8],[9,10,11]]], [[1,3],[2,4]]])
+def test_onnx_export_arange_like(tmp_path, dtype, axis, test_data):

Review comment:
       Can you also check the step option in the tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org