You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by pi...@apache.org on 2021/02/12 19:32:42 UTC

[submarine] branch master updated: SUBMARINE-734. Open a new page when clicking tensorboard button

This is an automated email from the ASF dual-hosted git repository.

pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 18bd0cd  SUBMARINE-734. Open a new page when clicking tensorboard button
18bd0cd is described below

commit 18bd0cd79822b5abfb8d6699cbbeae8ff1d0547f
Author: ByronHsu <by...@gmail.com>
AuthorDate: Tue Feb 9 15:03:25 2021 +0800

    SUBMARINE-734. Open a new page when clicking tensorboard button
    
    ### What is this PR for?
    Currently, the tensorboard button will redirect the user to the tensorboard web on the same page. However, it is more convenient if we can create an additional webpage for users.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-734
    
    ### How should this be tested?
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: ByronHsu <by...@gmail.com>
    
    Signed-off-by: Kevin <pi...@apache.org>
    
    Closes #509 from ByronHsu/TFBOARD_NEW_WINDOW and squashes the following commits:
    
    d8f4c64b [ByronHsu] create a new page when linking to tensorborad
---
 .../workbench/experiment/experiment-home/experiment-home.component.html  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-home.component.html b/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-home.component.html
index ff8a468..99fb8ca 100644
--- a/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-home.component.html
+++ b/submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-home.component.html
@@ -26,6 +26,7 @@
     </nz-radio-group>
     <a
       nz-button
+      target="_blank"
       nzType="primary"
       style="margin: 0px 4px 0px 4px"
       [nzLoading]="isTensorboardLoading"


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org