You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/18 10:41:23 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1786: fix: historical comments issues

juzhiyuan commented on a change in pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#discussion_r615379113



##########
File path: web/src/components/Plugin/UI/cors.tsx
##########
@@ -57,9 +57,9 @@ const Cors: React.FC<Props> = ({ form }) => {
             <Select
               mode="multiple"
               optionLabelProp="label"
-              onChange={(value) => {
-                ((value as string[]).join(","));
-                if ((value as string[]).includes('*')) {
+              onChange={(value: string[]) => {
+                value.join(",")

Review comment:
       so why do we need this line?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org