[PR] test(llm): cover missing and empty failure message fallbacks [rocketmq-dashboard]

["chstercc (via GitHub)" <gi...@apache.org>]

chstercc opened a new pull request, #5489:
URL: https://github.com/apache/rocketmq-dashboard/pull/5489

   ### Which Issue(s) This PR Fixes
   
   - Fixes #4030
   
   ### Brief Description
   
   Expand the existing LLM failure-result tests to cover:
   - Undefined responses.
   - Missing or empty error messages falling back to the caller's message while preserving diagnostic `code` and `hint`.
   
   Only the existing test file changes; runtime behavior is unchanged.
   
   ### How Did You Test This Change?
   
   - Focused LLM settings tests: 7 passed.
   - `cd web && npm test -- --maxWorkers=2`: 147 test files, 1389 tests passed.
   - `npm run lint`: 0 errors, 10 existing warnings.
   - Prettier and `git diff --check`: passed.
   - Mutation check: replacing `||` with `??` made the new empty-message test fail as expected; the original implementation was restored.
   - `npm run build`: TypeScript compilation and Vite bundling passed, but the license artifact verification failed. The same failure was reproduced on unchanged upstream code.
   
   Backend tests were not run because this change only adds frontend tests.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits
   - [x] Regression tests added, with test names ending in `Test`
   - [x] Formatting and diff checks passed
   - [x] Existing ASF license header preserved
   - [ ] Full build passes — blocked by the existing license artifact verification failure
   
   No new UI text, source files, runtime behavior, or architecture changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(llm): cover missing and empty failure message fallbacks [rocketmq-dashboard]

["chstercc (via GitHub)" <gi...@apache.org>]

chstercc commented on PR #5489:
URL: https://github.com/apache/rocketmq-dashboard/pull/5489#issuecomment-6076064485

   @lizhimins Addressed in 3348c62b using option (a). applyTestResult now calls buildLlmFailureResult, and the failure alert displays the diagnostic code and hint. Added UI tests for provided, missing, and empty error messages; removed the redundant undefined-response case and improved the parameterized titles. Changing || to ?? now fails the empty-message UI test. All 18 related tests pass. Could you please take another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org