[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1014: add rbac logic

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #1014:
URL: https://github.com/apache/servicecomb-service-center/pull/1014#discussion_r639753918



##########
File path: server/plugin/auth/buildin/buildin.go
##########
@@ -25,13 +25,14 @@ import (
 	"strings"
 
 	"github.com/apache/servicecomb-service-center/pkg/plugin"
-	"github.com/go-chassis/cari/rbac"
+	rbacModel "github.com/go-chassis/cari/rbac"

Review comment:
       rbac包并不是提供模型的包，所以保持原状

##########
File path: server/plugin/auth/buildin/buildin.go
##########
@@ -48,86 +49,113 @@ type TokenAuthenticator struct {
 }
 
 func (ba *TokenAuthenticator) Identify(req *http.Request) error {
-	if !rbacsvc.Enabled() {
+	if !rbac.Enabled() {

Review comment:
       这个事sc的rbacsvc，保持原状




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org