[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7592: arch/stm32/1wire: Don't free the context if the reference doesn't equal zero

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #7592:
URL: https://github.com/apache/incubator-nuttx/pull/7592#discussion_r1021222117


##########
arch/arm/src/stm32/stm32_1wire.c:
##########
@@ -1273,7 +1273,6 @@ int stm32_1wireuninitialize(struct onewire_dev_s *dev)
   if (--priv->refs)
     {
       nxmutex_unlock(&priv->lock);
-      kmm_free(priv);

Review Comment:
   The above cod access cref without lock, but here with lock. I think we need to fix that to access lock protected only



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org