You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by us...@apache.org on 2017/09/08 15:42:11 UTC
lucene-solr:branch_7_0: LUCENE-7963: Remove useless getAttribute() in
DefaultIndexingChain that causes performance drop, introduced by LUCENE-7626
Repository: lucene-solr
Updated Branches:
refs/heads/branch_7_0 8faa08baf -> 3ba304b29
LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that causes performance drop, introduced by LUCENE-7626
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/3ba304b2
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/3ba304b2
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/3ba304b2
Branch: refs/heads/branch_7_0
Commit: 3ba304b29825a94249c5145b3f5061e87b87d8f8
Parents: 8faa08b
Author: Uwe Schindler <us...@apache.org>
Authored: Fri Sep 8 17:39:12 2017 +0200
Committer: Uwe Schindler <us...@apache.org>
Committed: Fri Sep 8 17:41:54 2017 +0200
----------------------------------------------------------------------
lucene/CHANGES.txt | 4 ++++
.../src/java/org/apache/lucene/index/DefaultIndexingChain.java | 2 --
2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/3ba304b2/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 1e1bdd1..9a176c8 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -132,6 +132,10 @@ Bug Fixes
* LUCENE-7956: Fixed potential stack overflow error in ICUNormalizer2CharFilter.
(Adrien Grand)
+* LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that
+ causes performance drop, introduced by LUCENE-7626. (Daniel Mitterdorfer
+ via Uwe Schindler)
+
Improvements
* LUCENE-7489: Better storage of sparse doc-values fields with the default
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/3ba304b2/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java b/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
index f2c3de1..fd24105 100644
--- a/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
+++ b/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
@@ -27,7 +27,6 @@ import java.util.Map;
import java.util.Set;
import org.apache.lucene.analysis.TokenStream;
-import org.apache.lucene.analysis.tokenattributes.CharTermAttribute;
import org.apache.lucene.codecs.DocValuesConsumer;
import org.apache.lucene.codecs.DocValuesFormat;
import org.apache.lucene.codecs.NormsConsumer;
@@ -733,7 +732,6 @@ final class DefaultIndexingChain extends DocConsumer {
stream.reset();
invertState.setAttributeSource(stream);
termsHashPerField.start(field, first);
- CharTermAttribute termAtt = tokenStream.getAttribute(CharTermAttribute.class);
while (stream.incrementToken()) {