[GitHub] [apisix-ingress-controller] SergeBakharev commented on a change in pull request #657: docs: correct helm repo

[GitBox <gi...@apache.org>]

SergeBakharev commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699713916



##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
 As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
 
 ```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami

Review comment:
       Ah I now understand, the `cd /path/to/apisix-helm-chart` step is because we are expecting the user to have a local copy of the chart, thus the `helm install apisix charts/apisix` is referring to a relative path on the local file system not a repo. This was not immediately obvious because the chart is not present in this repo.
   
   I think it would be best if the install documentation used a helm repo, but I see you are considering moving hosting to github.
   
   Can I suggest an explicit step to clone the helm chart from github until the repo hosting is resolved?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org