You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/07 17:43:52 UTC

[PR] mima comparison failing [incubator-pekko-grpc]

pjfanning opened a new pull request, #224:
URL: https://github.com/apache/incubator-pekko-grpc/pull/224

   issue is that previousStableVersion only looks at git tags and we have a v1.1.0-M0 git tag but no release of that name


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] mima comparison failing [incubator-pekko-grpc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #224:
URL: https://github.com/apache/incubator-pekko-grpc/pull/224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] mima comparison failing [incubator-pekko-grpc]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #224:
URL: https://github.com/apache/incubator-pekko-grpc/pull/224#issuecomment-1933784371

   > Do we expect this to be an exceptional situation or something that happens regularly? If the former, we should add an issue to remind us to remove the workaround after the 1.1.0 release. If the latter, we should add updating this value to the release procedure.
   
   This is normal, we have to create a `M0` tag when we bump a major/minor so that nightly snapshots start using that new bumped major/minor version.
   
   i.e. if we are at 1.1.x and we decide to bump the minor version we have to create a 1.2.0-M0 tag along with a branch so that nightly job will create versions starting with 1.2.0-x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] mima comparison failing [incubator-pekko-grpc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #224:
URL: https://github.com/apache/incubator-pekko-grpc/pull/224#issuecomment-1933638374

   I raised https://github.com/sbt/sbt-dynver/issues/283
   
   In theory, we could submit such a fix ourselves and if it isn't merged, we can add it to one of our own sbt plugins.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org