[GitHub] [geode] albertogpz opened a new pull request #6633: Revert "GEODE-8971: Add grace period when stopping gateway sender wit…

[GitBox <gi...@apache.org>]

albertogpz opened a new pull request #6633:
URL: https://github.com/apache/geode/pull/6633


   …h group-… (#6052)"
   
   This reverts commit 841fa06c7b34916c09df920b7029974a78255cd0.
   
   The reason is that this commit creates problems with ongoing
   put operations during the grace period (very long response
   times) and also, if operations rate is high, it could prevent
   that the gateway sender is stopped.
   
   Put operations can be very slow during the grace period
   because they need to traverse the gateway sender queue
   to find events with the same transactionId. If the queue
   size is big and events are evicted to disk, the time to
   process a request can be unacceptably long.
   At the same time, this can provoke that the gateway sender
   is never stopped because it is blocked trying to get
   a write lock and the lock is held by ongoing operations
   for a long time.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] albertogpz closed pull request #6633: Revert "GEODE-8971: Add grace period when stopping gateway sender wit…

[GitBox <gi...@apache.org>]

albertogpz closed pull request #6633:
URL: https://github.com/apache/geode/pull/6633


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org