You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/17 14:16:10 UTC

[GitHub] [skywalking] kezhenxu94 opened a new pull request #8142: Set up QEMU and Buildx in GHA to support cross platform

kezhenxu94 opened a new pull request #8142:
URL: https://github.com/apache/skywalking/pull/8142


   verified in https://github.com/apache/skywalking/runs/4239030853?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #8142: Set up QEMU and Buildx in GHA to support cross platform

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8142:
URL: https://github.com/apache/skywalking/pull/8142#discussion_r751313093



##########
File path: .github/workflows/publish-docker.yaml
##########
@@ -52,5 +52,9 @@ jobs:
           registry: ${{ env.HUB }}
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
+      - name: Set up QEMU

Review comment:
       How about Linux(Ubuntu for example)? I was building all release(binary, source tar and image) on GCP Linux




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #8142: Set up QEMU and Buildx in GHA to support cross platform

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8142:
URL: https://github.com/apache/skywalking/pull/8142#discussion_r751300821



##########
File path: .github/workflows/publish-docker.yaml
##########
@@ -52,5 +52,9 @@ jobs:
           registry: ${{ env.HUB }}
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
+      - name: Set up QEMU

Review comment:
       QEMU, interesting. Anything needs to be added for release document when do container image? I feel there are some extra setups.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8142: Set up QEMU and Buildx in GHA to support cross platform

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #8142:
URL: https://github.com/apache/skywalking/pull/8142#discussion_r751305044



##########
File path: .github/workflows/publish-docker.yaml
##########
@@ -52,5 +52,9 @@ jobs:
           registry: ${{ env.HUB }}
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
+      - name: Set up QEMU

Review comment:
       > QEMU, interesting. Anything needs to be added for release document when do container image? I feel there are some extra setups.
   
   <img width="754" alt="Screen Shot 2021-11-17 at 22 37 14" src="https://user-images.githubusercontent.com/15965696/142220847-71c032eb-5359-4757-9c8e-50f964f5fe01.png">
   
   For maintainers using Mac OS, a Docker Desktop is just enough to release the images, as tested in https://hub.docker.com/repository/docker/kezhenxu94/oap/tags?page=1&ordering=last_updated
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng merged pull request #8142: Set up QEMU and Buildx in GHA to support cross platform

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #8142:
URL: https://github.com/apache/skywalking/pull/8142


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org