You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2006/02/16 21:59:11 UTC

DO NOT REPLY [Bug 38687] New: - Module controller does not work in non-GUI mode

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687

           Summary: Module controller does not work in non-GUI mode
           Product: JMeter
           Version: 2.1.1
          Platform: All
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: sebb@apache.org


The Module Controller does not work in non-GUI mode.

This seems to be because it uses the GuiPackage to find the test tree.

Although non-GUI test runs cannot access WorkBench items, the Module 
Controller can also refer to modules defined in the current thread-group, even 
if these are disabled or as children of an If controller with a permanently 
false condition.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: DO NOT REPLY [Bug 38687] New: - Module controller does not work in non-GUI mode

Posted by sebb <se...@gmail.com>.
Pity, because MC would be an alternative for some test plans...

I might have a go at fixing MC ...

S.
On 16/02/06, Peter Lin <wo...@gmail.com> wrote:
> that makes sense, since I coped modulecontroller :)
>
> so I guess copying ModuleController to make IncludeController served to
> expose a bug in ModuleController
>
> peter
>
>
> On 2/16/06, bugzilla@apache.org <bu...@apache.org> wrote:
> >
> > DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
> > RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> > <http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
> > ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
> > INSERTED IN THE BUG DATABASE.
> >
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=38687
> >
> >            Summary: Module controller does not work in non-GUI mode
> >            Product: JMeter
> >            Version: 2.1.1
> >           Platform: All
> >         OS/Version: other
> >             Status: NEW
> >           Severity: normal
> >           Priority: P1
> >          Component: Main
> >         AssignedTo: jmeter-dev@jakarta.apache.org
> >         ReportedBy: sebb@apache.org
> >
> >
> > The Module Controller does not work in non-GUI mode.
> >
> > This seems to be because it uses the GuiPackage to find the test tree.
> >
> > Although non-GUI test runs cannot access WorkBench items, the Module
> > Controller can also refer to modules defined in the current thread-group,
> > even
> > if these are disabled or as children of an If controller with a
> > permanently
> > false condition.
> >
> > --
> > Configure bugmail:
> > http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> > ------- You are receiving this mail because: -------
> > You are the assignee for the bug, or are watching the assignee.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
> >
> >
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: DO NOT REPLY [Bug 38687] New: - Module controller does not work in non-GUI mode

Posted by Peter Lin <wo...@gmail.com>.
that makes sense, since I coped modulecontroller :)

so I guess copying ModuleController to make IncludeController served to
expose a bug in ModuleController

peter


On 2/16/06, bugzilla@apache.org <bu...@apache.org> wrote:
>
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> <http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
> INSERTED IN THE BUG DATABASE.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=38687
>
>            Summary: Module controller does not work in non-GUI mode
>            Product: JMeter
>            Version: 2.1.1
>           Platform: All
>         OS/Version: other
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Main
>         AssignedTo: jmeter-dev@jakarta.apache.org
>         ReportedBy: sebb@apache.org
>
>
> The Module Controller does not work in non-GUI mode.
>
> This seems to be because it uses the GuiPackage to find the test tree.
>
> Although non-GUI test runs cannot access WorkBench items, the Module
> Controller can also refer to modules defined in the current thread-group,
> even
> if these are disabled or as children of an If controller with a
> permanently
> false condition.
>
> --
> Configure bugmail:
> http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
>
>

DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687





------- Additional Comments From sebb@apache.org  2006-02-17 20:42 -------
It seems that the ReplaceableController interface special handling is done 
only in the AbstractAction class - which is currently only called in GUI mode.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687





------- Additional Comments From guillaume.lasnier@sungard.com  2006-09-15 08:20 -------
The issue only applies to the Module Controller. Include Controller are
correclty resolved resolved in non GUI mode.
Has someone started to work on this issue?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Additional Comments From sebb@apache.org  2007-09-02 04:46 -------
I found a problem with the code when running non-GUI on a box without a real 
display. Setting java.awt.headless=true fixed it, but this is not a full 
solution.

The cause of the problem is in JMeterTreeModel, which creates various Gui 
objects. This is needed by ReplaceableController.resolveReplacementSubTree().

Changing the tree resolver to use the testPlan HashTree rather than 
JMeterTreeNode looked rather difficult, so I added a hack to create a 
TreeModel that does not use any GUI items.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |LATER




------- Additional Comments From sebb@apache.org  2007-09-02 04:47 -------
This should probably be tidied up at some point...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687





------- Additional Comments From guillaume.lasnier@sungard.com  2006-09-18 11:51 -------
Created an attachment (id=18880)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18880&action=view)
Correction

This patch fixes the problem by adding a method to ReplaceableController to
help resolving the replacement subtree. Resolution takes an generic Object,
which is used by ModuleController to search for the selected test element.
Initially this resolution was kind of hacky since it looked for the root node
in the GuiPackage. This works fine in GUI mode but as mentionned in your
comments is not suitable in non GUI. In this mode, resolution is performed just
after load the TestPlan in the JMeter class.
The conversion of Test node has also been refactored in the JMeter class.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687





------- Additional Comments From woolfel@yahoo.com  2006-02-17 20:51 -------
so it sounds like we need a general solution that will work for both module and
include controller

peter

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687





------- Additional Comments From christoph.schragen@gmx.at  2007-08-31 00:53 -------
Created an attachment (id=20749)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20749&action=view)
Correction patch for R2.3

i made a new patch against release 2.3 by using your patch, as we need that for
our application. this patch may be easily applied to release 2.3 (and is only
15 kb and not 73 kb).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 38687] - Module controller does not work in non-GUI mode

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38687>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38687


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-08-31 09:53 -------
Excellent - thanks very much.

The patch (20749) works fine.

I've applied it with a minor tweak - convertSubTree() is no longer needed in 
AbstractAction.

SVN updates: r571515 r571519 r571520

Also r571514 - update to test code to demonstrate bug.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org