You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2019/01/29 17:14:29 UTC

[royale-asjs] branch develop updated: Language: workaround that is closer to the original (references apache/royale-compiler#74)

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 00f0de9  Language: workaround that is closer to the original (references apache/royale-compiler#74)
00f0de9 is described below

commit 00f0de99aeb8a21bf1c88fdce95fa8ad0e4a942b
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Tue Jan 29 09:13:42 2019 -0800

    Language: workaround that is closer to the original (references apache/royale-compiler#74)
---
 .../Language/src/main/royale/org/apache/royale/utils/Language.as      | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as b/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
index 9887ff7..89d391d 100644
--- a/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
+++ b/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
@@ -112,9 +112,7 @@ package org.apache.royale.utils
 		 */
 		static public function string(value:*):String
 		{
-			if(value == null)
-				return null;
-			return value.toString() as String;
+			return (value == null ? null : value.toString()) as String;
 		}
 
 		/**


Re: [royale-asjs] branch develop updated: Language: workaround that is closer to the original (references apache/royale-compiler#74)

Posted by Harbs <ha...@gmail.com>.
Ah. No. Different parens…

> On Jan 29, 2019, at 7:23 PM, Harbs <ha...@gmail.com> wrote:
> 
> I’m pretty sure I tried that and it did not work.
> 
> Isn’t that the same as my first commit?
> 
>> On Jan 29, 2019, at 7:14 PM, joshtynjala@apache.org wrote:
>> 
>> This is an automated email from the ASF dual-hosted git repository.
>> 
>> joshtynjala pushed a commit to branch develop
>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> 
>> 
>> The following commit(s) were added to refs/heads/develop by this push:
>>    new 00f0de9  Language: workaround that is closer to the original (references apache/royale-compiler#74)
>> 00f0de9 is described below
>> 
>> commit 00f0de99aeb8a21bf1c88fdce95fa8ad0e4a942b
>> Author: Josh Tynjala <jo...@apache.org>
>> AuthorDate: Tue Jan 29 09:13:42 2019 -0800
>> 
>>   Language: workaround that is closer to the original (references apache/royale-compiler#74)
>> ---
>> .../Language/src/main/royale/org/apache/royale/utils/Language.as      | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>> 
>> diff --git a/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as b/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
>> index 9887ff7..89d391d 100644
>> --- a/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
>> +++ b/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
>> @@ -112,9 +112,7 @@ package org.apache.royale.utils
>> 		 */
>> 		static public function string(value:*):String
>> 		{
>> -			if(value == null)
>> -				return null;
>> -			return value.toString() as String;
>> +			return (value == null ? null : value.toString()) as String;
>> 		}
>> 
>> 		/**
>> 
> 


Re: [royale-asjs] branch develop updated: Language: workaround that is closer to the original (references apache/royale-compiler#74)

Posted by Harbs <ha...@gmail.com>.
I’m pretty sure I tried that and it did not work.

Isn’t that the same as my first commit?

> On Jan 29, 2019, at 7:14 PM, joshtynjala@apache.org wrote:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> joshtynjala pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> 
> 
> The following commit(s) were added to refs/heads/develop by this push:
>     new 00f0de9  Language: workaround that is closer to the original (references apache/royale-compiler#74)
> 00f0de9 is described below
> 
> commit 00f0de99aeb8a21bf1c88fdce95fa8ad0e4a942b
> Author: Josh Tynjala <jo...@apache.org>
> AuthorDate: Tue Jan 29 09:13:42 2019 -0800
> 
>    Language: workaround that is closer to the original (references apache/royale-compiler#74)
> ---
> .../Language/src/main/royale/org/apache/royale/utils/Language.as      | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as b/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
> index 9887ff7..89d391d 100644
> --- a/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
> +++ b/frameworks/projects/Language/src/main/royale/org/apache/royale/utils/Language.as
> @@ -112,9 +112,7 @@ package org.apache.royale.utils
> 		 */
> 		static public function string(value:*):String
> 		{
> -			if(value == null)
> -				return null;
> -			return value.toString() as String;
> +			return (value == null ? null : value.toString()) as String;
> 		}
> 
> 		/**
>