You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/05 03:12:26 UTC

[GitHub] [rocketmq-mqtt] tianliuliu commented on a diff in pull request #90: [ISSUE #22] codeCov for mqtt.cs.session

tianliuliu commented on code in PR #90:
URL: https://github.com/apache/rocketmq-mqtt/pull/90#discussion_r865527788


##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/Session.java:
##########
@@ -142,9 +142,7 @@ public Map<Subscription, Map<Queue, QueueOffset>> offsetMapSnapshot() {
             }
             Map<Queue, QueueOffset> queueMap = new HashMap<>(8);

Review Comment:
   the size 8 can be replaced by offsetMap.get(queueName).size()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org