You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/10 11:42:50 UTC
[GitHub] [tvm] MichaelJKlaiber opened a new issue, #11260: [RFC][Tracking Issue] UMA: Universal Modular Accelerator Interface
MichaelJKlaiber opened a new issue, #11260:
URL: https://github.com/apache/tvm/issues/11260
This is a global tracking issue for landing the initial PRs of **UMA**. The original RFC can be found [here](https://github.com/boschresearch/tvm-rfcs/blob/rfc_uma/rfcs/00xx_UMA_Unified_Modular_Accelerator_Interface.md). Please feel free to bring in more questions to the corresponding thread.
To make the improvement manageable, we will be breaking the code into several steps. The main architecture scaffolding and
data structure changes will come first, then we will upstream individual key features.
# Steps
- [ ] P1: TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cbalint13 commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
cbalint13 commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1144927868
@MichaelJKlaiber ,
This is really great work, congratulations !
Watching with interest this ntiative, allow me to ask questions towards ***100% out-of-tree*** functionality.
#### Case usage:
----
Given the case of a custom risc-v (or any llvm cpu) ISA extension (i.e. [custom HW/ISA](https://github.com/cbalint13/OLIMP) that itself can change&autotunne):
* Currently (without UMA) it is necessary to **fork & insert** into TVM codebase:
1. new strategies:
```python/tvm/relay/op/strategy/__init__.py```
```python/tvm/relay/op/strategy/olimp.py```
2. new target:
```python/tvm/target/__init__.py```
```python/tvm/target/target.py```
3. some new topi that includes (auto)tensorization:
```python/tvm/topi/olimp/__init__.py```
```python/tvm/topi/olimp/conv2d.py```
```python/tvm/topi/olimp/dense.py```
```python/tvm/topi/olimp/injective.py```
```python/tvm/topi/olimp/tensor_intrin.py```
Now after these **"C" code & binary libs** can be emmited that include **inline asm calls** with tensorized custom ISA.
All **operators not covered** by declared **new strategies** defaults to **"the generic tvm"** not taking custom ISA advantage.
----
#### Now the questions:
* Will UMA permit such workflow **without touching** and maintain a separate TVM fork / codebase ?
* [UMA RFC](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0060_UMA_Unified_Modular_Accelerator_Interface.md) tells to register a UMA (with nice class properties overrides) will all this be possible **100% out-of tree** ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] qzylalala commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by "qzylalala (via GitHub)" <gi...@apache.org>.
qzylalala commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1523024661
Hi, thanks for the work. Does this issue still active?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
areusch commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1281061418
@xinetzone do you mind filing a separate issue and including some more detail (i.e. is there a stacktrace)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] fabianpedd commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
fabianpedd commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1281185750
@xinetzone there is a PR for that already #12731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
areusch commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1140008848
@gfvvz @MichaelJKlaiber FYI the tracking issue https://github.com/apache/tvm/issues/11260 should be the place we list that sort of thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gfvvz commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
gfvvz commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1138626724
Hi, thanks for the work. Just want to know if there is a rough schedule on these features development?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Tracking Issue] UMA: Universal Modular Accelerator Interface [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
URL: https://github.com/apache/tvm/issues/11260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
areusch commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1281450587
oh yes, thanks for the reminder @fabianpedd :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MichaelJKlaiber commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
MichaelJKlaiber commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1168448431
@gfvvz , just added the link to our working branch, feel free to peek into (partially finished) functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MichaelJKlaiber commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
MichaelJKlaiber commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1139332486
Hi @gfvvz , that's a great question. I'll try to come up with an answer asap. If you have input or feedback, feel free to reach out any time via Discord, GitHub or the TVM community forum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] xinetzone commented on issue #11260: [Tracking Issue] UMA: Universal Modular Accelerator Interface
Posted by GitBox <gi...@apache.org>.
xinetzone commented on issue #11260:
URL: https://github.com/apache/tvm/issues/11260#issuecomment-1275449937
`python/tvm/relay/backend/contrib/uma/backend.py` has a bugļ¼
```python
for name, attr in self._target_attrs:
if attr is None:
raise ValueError("Target attribute None is not supported.")
```
can use:
```python
for attr in self._target_attrs.values():
if attr is None:
raise ValueError("Target attribute None is not supported.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org