You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/05/29 08:24:07 UTC

[GitHub] [singa] dcslin opened a new pull request #713: impl new opt api, decay scheduler constant class, optimzer class, sgd…

dcslin opened a new pull request #713:
URL: https://github.com/apache/singa/pull/713


   … momentum, dampening, added unit test, backward compatibility tested


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-635946332


   This pull request **introduces 1 alert** when merging bd6f1a6fb24d941fe4aa17f4ecbee85feee7976f into bec19640aa7dae75cd12a44109bc319d2e30cfbf - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-b295cad079e0c513f9b312a7d00e4bb3010af586)
   
   **new alerts:**
   
   * 1 for Unused local variable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-635847218


   This pull request **introduces 2 alerts** when merging c38a1910252ec5564f1f6bc2a3d9fada49f2d2ee into bec19640aa7dae75cd12a44109bc319d2e30cfbf - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-49926dc14a39c9f09182f25ef210113076e87607)
   
   **new alerts:**
   
   * 1 for First parameter of a method is not named &#39;self&#39;
   * 1 for Mismatch between signature and use of an overridden method


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles merged pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
nudles merged pull request #713:
URL: https://github.com/apache/singa/pull/713


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-636308490


   This pull request **introduces 1 alert** when merging 794ab386c53b977ac1e8f2898901ae862d714ff6 into bec19640aa7dae75cd12a44109bc319d2e30cfbf - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-e61eb6b5fcecc8f24d3297f0e6c4491b72530ade)
   
   **new alerts:**
   
   * 1 for Unused local variable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] dcslin commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-635843614


   opened as separate PR for ease of review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-636319825


   This pull request **introduces 1 alert** when merging 621dc4bb920bfaa9484e029a56f8653a1e12d9b4 into bec19640aa7dae75cd12a44109bc319d2e30cfbf - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-09071da2a0b1c20322b1c08ac43a48d713104230)
   
   **new alerts:**
   
   * 1 for Unused local variable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-639649460


   This pull request **introduces 1 alert** and **fixes 9** when merging 799283f051ac6201aef0d6a6edb170ce1a7daaba into 038e2df29922112cf0e6125460cd6b254e7598ec - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-198eba464b1372e63cd6d5cbddbbff2e34876b58)
   
   **new alerts:**
   
   * 1 for Unused import
   
   **fixed alerts:**
   
   * 8 for Unused import
   * 1 for Unreachable code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] dcslin commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-636306984


   checking test cases errors


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] dcslin commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-636267759


   checking linting


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] dcslin edited a comment on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
dcslin edited a comment on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-635843614


   opened as separate PR for ease of review.
   Document reference: https://gist.github.com/nudles/d7f8043f251872333ec06f2701696cce
   other model api revamp: https://github.com/apache/singa/pull/697


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-640026056


   This pull request **fixes 9 alerts** when merging 735cafbf0e71f57b992efd8440289f52e273a411 into 038e2df29922112cf0e6125460cd6b254e7598ec - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-096f71e1f331725acee3c9c00f6c733d4fa325e8)
   
   **fixed alerts:**
   
   * 8 for Unused import
   * 1 for Unreachable code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] dcslin commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-636426229


   As highlighted by rulin, currently test case nesterov on gpu could not pass. Other tests are passing.
   But in new API and backward compatibility perspective, it is ready for merged.
   I am looking into the nesterov gpu case for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #713:
URL: https://github.com/apache/singa/pull/713#issuecomment-636419215


   This pull request **introduces 1 alert** when merging f5f96d552dfe83ead4db2e2ec89cfc59af33f94f into dd18aff58aafe29b2984c884fad7e453bfe2d507 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-45d84ebba2ee6eaceeb75c346c9d0076360be83b)
   
   **new alerts:**
   
   * 1 for Unused local variable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles merged pull request #713: impl new opt api

Posted by GitBox <gi...@apache.org>.
nudles merged pull request #713:
URL: https://github.com/apache/singa/pull/713


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org