[GitHub] [incubator-nuttx] patacongo commented on pull request #3475: drivers/input: Add TOUCHSCREEN config and add NX_XYINPUT dependencies

[GitBox <gi...@apache.org>]

patacongo commented on pull request #3475:
URL: https://github.com/apache/incubator-nuttx/pull/3475#issuecomment-815284115


   One thing that I tried to do in the past was establish some conventions for configuration naming.  I was not very successful in that as there are many, many configuration naming consistencies.
   
   I think that I tried to enforce was to include the name of the directory where a configuration is defined OR part of the name of the configuration that enables this one.  You will see that most but not all configurations follow this convention.  CONFIG_INPUT, for example, does not.  Per that convention, it should be CONFIG_DRIVERS_INPUT.  Then all of the top level configurations defined in that directory should be CONFIG_INPUT_*.  So for example, CONFIG_TOUCHSCREEN should be CONFIG_INPUT_TOUCHSCREEN.
   
   This has the advantage that (1) by the name of the configuration, you (usually) know which Konfig file it is defined in and (2) it prevents configuration naming collisions.  Kconfig variable name collisions are especially nasty because usually not error is generated when the redundant names are used.
   
   We should come to an agreement as a group about configuration naming.  Should we continue to try to follow this convention?  Should we abandon it altogether?  Should we establish a different convention for configuration names?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org