You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by vherilier <gi...@git.apache.org> on 2016/12/02 16:52:59 UTC
[GitHub] jmeter pull request #236: Bug 59937: Sub menus addition
GitHub user vherilier opened a pull request:
https://github.com/apache/jmeter/pull/236
Bug 59937: Sub menus addition
JMeter must offer developers to place elements in sub-menus too to improve the user experience.
It is realised by introducing the "drawer" property into "MenuInfo".
The "MenuFactory" uses this property to place or not the "MenuItem" into a sub "JMenu".
This property is defined for both JMeter element kinds (Graphical or BeanInfo).
Like the "menuCategories" do, "subMenuCategories" offers to place an element into multiple places (root menu and/or one/several submenus).
The definition is made like following:
* Graphical kind:
By Adding the "getSubMenuCategories()" method in the GUI related class and defining the returned String array:
** "null" or [""]: lets the item in the root of the related category menu.
** ["AAA"]: places the item into the sub menu name "AAA"
** ["AAA", "BBB"]: places the item into the sub menu name "AAA" and into the sub menu "BBB"
** ["", "AAA"]: places the item into the root of the related category menu and into sub menu name "AAA".
NB: If the method is missing, it does change nothing. the item remains in the root of the related category menu.
NB: The sub menu names must be translated by the resources mechanism.
* BeanInfo kind:
By twisting the BeanInfo "shortDescription" property to get the translated sub menu names. Several places names must be separated by ";":
** property "shortDescription" undefined or set to "": lets the item in the root of the related category menu.
** "AAA": places the item into the sub menu name "AAA"
** "AAA;BBB: places the item into the sub menu name "AAA" and into the sub menu "BBB"
** ";AAA": places the item into the root of the related category menu and into sub menu name "AAA".
Warning: general and specific resources related string must be identical or different sub menus will appears.
===========================================================
Hope it will helpfull for other developpers, I really need it for my whole sets of plugins
I've gathered some protocol specific elements to show the efficency of the mechanism
Up to you to roll them back, gather them differently or change the name used for the submenus
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vherilier/jmeter sub_menus
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #236
----
commit 7c289b94d465fb24ae759fc5395514d17e6c26f4
Author: Vincent Herilier <vh...@gmail.com>
Date: 2016-12-02T16:29:18Z
introduce the submenu mechanism coming from the gui ot the beaninfo definiton
commit d47a53eb14785296ba4fb1e4dc3ab4426b532ed1
Author: Vincent Herilier <vh...@gmail.com>
Date: 2016-12-02T16:33:29Z
gather HTTP Protocol related elements
commit e81ff6b992bae3a616e7133492d638133390813f
Author: Vincent Herilier <vh...@gmail.com>
Date: 2016-12-02T16:34:51Z
Gather FTP Protocol related elements
commit c6de2317fe459de99d7d0425c29fa1c540ca2073
Author: Vincent Herilier <vh...@gmail.com>
Date: 2016-12-02T16:36:39Z
Gather JDBC elements into "Databases"
commit df1c3c23c44b44566a97a546a8a94fef91f7717b
Author: Vincent Herilier <vh...@gmail.com>
Date: 2016-12-02T16:38:11Z
Gathers LDAP Protocol related elements
commit e3d4da9c10cfa74fa2fed5860782ac5412a52b10
Author: Vincent Herilier <vh...@gmail.com>
Date: 2016-12-02T16:39:00Z
Gathers 'MongoDB' related elements into "Databases" too
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #236: Bug 59937: Sub menus addition
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/236
Thanks a lot for your screenshots which give a better view of the feature and your work on this.
Unfortunately As discussed in :
- https://bz.apache.org/bugzilla/show_bug.cgi?id=59937
And on dev mailing list discussion:
- "Submenus for JMeter elements"
There is no real agreement on this way of presenting test element as it introduces another level of sub menus.
The grouping by protocol is interesting but Sub Menu is not for me the most ergonomic way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #236: Bug 59937: Sub menus addition
Posted by vherilier <gi...@git.apache.org>.
Github user vherilier commented on the issue:
https://github.com/apache/jmeter/pull/236
Here's some screenshots (Only JMeter native elements are concerned by the submenu gathering):
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #236: Bug 59937: Sub menus addition
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #236: Bug 59937: Sub menus addition
Posted by vherilier <gi...@git.apache.org>.
Github user vherilier commented on the issue:
https://github.com/apache/jmeter/pull/236
I missed JMS elements and I surely missed other gathering cases
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #236: Bug 59937: Sub menus addition
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/236
Hello,
Thanks for contribution.
Could you provide a screenshot of what the result will look like ?
Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---