You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Paul Elschot (JIRA)" <ji...@apache.org> on 2008/11/01 12:57:44 UTC
[jira] Created: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
-------------------------------------------------------------------------------
Key: LUCENE-1436
URL: https://issues.apache.org/jira/browse/LUCENE-1436
Project: Lucene - Java
Issue Type: Improvement
Components: Search
Reporter: Paul Elschot
Priority: Trivial
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1436:
---------------------------------
Attachment: LUCENE-1436.patch
This also prepares for using Filters as clauses in BooleanQuery
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1436:
------------------------------------------
Assignee: Michael McCandless
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713217#action_12713217 ]
Michael McCandless commented on LUCENE-1436:
--------------------------------------------
I'm assuming the answer to my last question was "no", so I'll go ahead and make these 2 classes package private.
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711783#action_12711783 ]
Shai Erera commented on LUCENE-1436:
------------------------------------
I just hope this does not collide with LUCENE-1614. Note that in the follow-up issue to 1614 (the number is yet to be generated) I intend to change the logic in ReqExclScorer so that it conforms to the new semantics of DISI.
Why do we need to make this class package-private? Any particular reason besides not needing to worry about changes to back-compat in the future?
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711790#action_12711790 ]
Paul Elschot commented on LUCENE-1436:
--------------------------------------
This should only affect external code that uses the ReqExclScorer class.
>From the amount of reactions on that so far I think such code probably does not exist.
The move to DocIdSetIterator (superclass of Scorer) can be done because no score values are used on the excluded part. This is only a consequence of the extraction of the DocIdSetIterator superclass from Scorer.
So I don't expect LUCENE-1614 or new semantics of DISI to collide with this.
Also, I don't expect LUCENE-1614 to collide with LUCENE-1345 that allows filter as clause to boolean query.
Some time ago DisjunctionSumScorer was made private in a similar way.
ReqOptSumScorer could also be made package private, perhaps even at the same time as ReqExclScorer.
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711810#action_12711810 ]
Michael McCandless commented on LUCENE-1436:
--------------------------------------------
OK why don't we make both package private? Are there other classes BooleanScorer/2 are using that should be made package private?
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711753#action_12711753 ]
Michael McCandless commented on LUCENE-1436:
--------------------------------------------
Paul, this is technically a change in back-compat (since it's a public class, that this patch makes package private). Are you thinking it's just very unlikely this is used by anything except BooleanScorer2?
We also have at least ReqOptSumScorer (and maybe others?) which is public.
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711793#action_12711793 ]
Paul Elschot commented on LUCENE-1436:
--------------------------------------
The reason to make things package private is to have more freedom to change things lateron that are not really part of the public api now.
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Priority: Trivial
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1436) Make ReqExclScorer package private,
and use DocIdSetIterator for excluded part.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1436.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.9
> Make ReqExclScorer package private, and use DocIdSetIterator for excluded part.
> -------------------------------------------------------------------------------
>
> Key: LUCENE-1436
> URL: https://issues.apache.org/jira/browse/LUCENE-1436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1436.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org