[GitHub] [spark] srowen commented on a change in pull request #33196: [SPARK-35996][BUILD] Setting version to 3.3.0-SNAPSHOT

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #33196:
URL: https://github.com/apache/spark/pull/33196#discussion_r663229184



##########
File path: project/MimaExcludes.scala
##########
@@ -34,6 +34,10 @@ import com.typesafe.tools.mima.core.ProblemFilters._
  */
 object MimaExcludes {
 
+  // Exclude rules for 3.3.x
+  lazy val v33excludes = v32excludes ++ Seq(

Review comment:
       We need not address there here, but I'm wondering if we should carry forward all the previous excludes? In master (currently 3.3.0) we're only concerned with excluding changes since 3.2.x. If, somehow, a previous exclusion matched a new, legitimate breaking change of the same type, we'd be masking it, no? or maybe i'm not thinking about it correctly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org