You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 21:43:54 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26119: Enable pushing early image cache to ghdcr.io repo
potiuk opened a new pull request, #26119:
URL: https://github.com/apache/airflow/pull/26119
In order to react quicker to changes in setup.py, setup.cfg and
Dockerfiles, we can push an early image cache to the ghcr.io cache.
This build is done way before constraints are regenerated so it is
using the "current" constraints at the moment the merge happens.
This should be safe - if the image fails to build (we ignore that)
the cache will not be pushed, but if it will, then even if we merge
a new commit quickly and the rest of the build is cancelled, the
cache will be refreshed with new Dockerfile/setup.py/setup.cfg and
the subsequent builds will run much faster.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26119: Enable pushing early image cache to ghcr.io registry
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26119:
URL: https://github.com/apache/airflow/pull/26119#issuecomment-1234844458
This is a reasult of discussion with @o-nikolas and @mik-laj on Slack: https://apache-airflow.slack.com/archives/C015SLQF059/p1661905832810429
This change should make our cache of images much "fresher" even in case our main starts failing. It does not attempt to upgrade constraints - it will try to build the image with current constraints and push it as cache. This is done early in the build workflow and it will not wait for all tests to finish (like the final cache pushing which also upgrades constraints).
Result of this change will be that even if tests fail, if the images can be build and succeed, they will be pushed as cache quickly - and this will make subsequent builds to be much faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #26119: Enable pushing early image cache to ghcr.io registry
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on PR #26119:
URL: https://github.com/apache/airflow/pull/26119#issuecomment-1234881992
Thanks for the quick turnaround!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26119: Enable pushing early image cache to ghcr.io registry
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26119:
URL: https://github.com/apache/airflow/pull/26119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org