You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "David Wisneski (JIRA)" <ji...@apache.org> on 2006/08/17 00:48:13 UTC
[jira] Created: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
EJBQL grammar needs to be updated to relfect JPA specification
--------------------------------------------------------------
Key: OPENJPA-15
URL: http://issues.apache.org/jira/browse/OPENJPA-15
Project: OpenJPA
Issue Type: Bug
Components: query
Reporter: David Wisneski
when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Kevin Sutter <kw...@gmail.com>.
I've created https://issues.apache.org/jira/browse/OPENJPA-33 to track the
inclusion of a query engine test bucket.
On 8/22/06, Kevin Sutter <kw...@gmail.com> wrote:
>
>
> On 8/22/06, Abe White <aw...@bea.com> wrote:
> >
> >
> > I also think that checking in a test case with any significant patch
> > is critical. (You might point out that I've been making a lot of
> > commits, and I have not been committing test cases to go with them.
> > But the test cases for my commits do exist... unfortunately as part
> > of Kodo's test suite, which we have yet to migrate to OpenJPA.)
>
>
> We have the same issue... :-)
>
>
>
Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Kevin Sutter <kw...@gmail.com>.
On 8/22/06, Abe White <aw...@bea.com> wrote:
>
>
> I also think that checking in a test case with any significant patch
> is critical. (You might point out that I've been making a lot of
> commits, and I have not been committing test cases to go with them.
> But the test cases for my commits do exist... unfortunately as part
> of Kodo's test suite, which we have yet to migrate to OpenJPA.)
We have the same issue... :-)
Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Abe White <aw...@bea.com>.
> Sounds like a good plan. New or updated tests would be good to
> demonstrate
> that a fix works. Even if we would provide a working testcase with
> the fix,
> that would be a good way to populate our test bucket.
>
> Concerning all of the query related JIRA reports that have been
> opened, do
> we have a base set of testcases for query within OpenJPA? That is,
> do we
> have a query test framework that we should attempt to work within?
I also think that checking in a test case with any significant patch
is critical. (You might point out that I've been making a lot of
commits, and I have not been committing test cases to go with them.
But the test cases for my commits do exist... unfortunately as part
of Kodo's test suite, which we have yet to migrate to OpenJPA.)
And no, we don't have a framework for query test cases (or even
persistence-using cases in general) in OpenJPA right now.
_______________________________________________________________________
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Kevin Sutter <kw...@gmail.com>.
Marc,
We'll take a look and see what we find... Thanks for trying out the patch!
Kevin
On 8/22/06, Marc Prud'hommeaux <mp...@apache.org> wrote:
>
> Kevin-
>
> I applied your patch, but there were a couple problems with our local
> tests. This statement caused a parse error:
>
> "update kodo.kernel.AttachD x set x.dint = 1 where x.dint <>
> (select min(y.dint) from kodo.kernel.AttachD y)"
>
> 1) testBulkUpdate(kodo.query.TestJPQLExpressions)<4|false|0.9.0>
> org.apache.openjpa.util.UserException: An error occurred while
> parsing the query filter "update kodo.kernel.AttachD x set x.dint = 1
> where x.dint <> (select min(y.dint) from kodo.kernel.AttachD y)".
> Error message: The alias "PATH" was not declared in the statement
> (declared aliases are: {1}). All aliases must be declared in the
> "from" section of the JPQL statement.
> at
> org.apache.openjpa.kernel.exps.AbstractExpressionBuilder.parseException(
> AbstractExpressionBuilder.java:113)
> at
> org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getCandidateMetaDat
> a(JPQLExpressionBuilder.java:236)
> at
> org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getSubquery
> (JPQLExpressionBuilder.java:1127)
> at org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.eval
> (JPQLExpressionBuilder.java:1051)
> at
> org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getValue
> (JPQLExpressionBuilder.java:1364)
> at
> org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getValue
> (JPQLExpressionBuilder.java:1350)
> at org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.eval
> (JPQLExpressionBuilder.java:766)
> at
> org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getExpression
> (JPQLExpressionBuilder.java:1341)
> at org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.eval
> (JPQLExpressionBuilder.java:709)
> at
> org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.evalWhereClause
> (JPQLExpressionBuilder.java:492)
> at
> org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getQueryExpressions
> (JPQLExpressionBuilder.java:257)
> at org.apache.openjpa.kernel.jpql.JPQLParser.eval
> (JPQLParser.java:58)
>
>
> And this statement actually parsed, but it returned the wrong number
> of results for some reason (I'm guessing maybe because the subselect
> correlation was lost):
>
> "select d from kodo.kernel.AttachD d where exists (select a.aint
> from d.a a where a.aint = 1)"
>
> Do you think you can fix these problems and re-submit the patch?
>
>
>
> On Aug 22, 2006, at 2:39 PM, Kevin Sutter wrote:
>
> > Sounds like a good plan. New or updated tests would be good to
> > demonstrate
> > that a fix works. Even if we would provide a working testcase with
> > the fix,
> > that would be a good way to populate our test bucket.
> >
> > Concerning all of the query related JIRA reports that have been
> > opened, do
> > we have a base set of testcases for query within OpenJPA? That is,
> > do we
> > have a query test framework that we should attempt to work within?
> >
> > Thanks,
> > Kevin
> >
> > On 8/22/06, Patrick Linskey <pl...@bea.com> wrote:
> >>
> >> (Note that my response here doesn't really answer your question.)
> >>
> >> I think that it's good that we've been using JIRA to store
> >> information
> >> about changes we're making, but I think it's far more important
> >> that we
> >> create test cases that demonstrate the old bad behavior and assert
> >> the
> >> new good behavior. That is, I'd like to see us create tests that fail
> >> against the old version of OpenJPA but pass once the patch is
> >> applied.
> >>
> >> One difficulty with this, of course, is that currently things are
> >> set up
> >> so that all tests must pass during a normal compilation. Does anyone
> >> know of a way to designate to mvn that certain tests are expected to
> >> fail, so that we can commit tests that break along with JIRA reports?
> >>
> >> -Patrick
> >>
> >> --
> >> Patrick Linskey
> >> BEA Systems, Inc.
> >>
> >> > -----Original Message-----
> >> > From: Kevin Sutter [mailto:kwsutter@gmail.com]
> >> > Sent: Tuesday, August 22, 2006 2:21 PM
> >> > To: open-jpa-dev@incubator.apache.org
> >> > Subject: Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs
> >> > to be updated to relfect JPA specification
> >> >
> >> > Now that we have successfully created a patch for OPENJPA-15,
> >> > what is the
> >> > process for getting this validated and hopefully accepted
> >> > into SVN? I have
> >> > been able to verify that the patch can be applied, everything
> >> > builds, and
> >> > the existing testcases still work. But, I'm not an expert
> >> > with the code
> >> > that is being updated, so it would be good for another
> >> > committer to verify
> >> > the changes.
> >> >
> >> > Thanks!
> >> > Kevin
> >> >
> >> > On 8/22/06, Catalina Wei (JIRA) <ji...@apache.org> wrote:
> >> > >
> >> > > [ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
> >> > >
> >> > > Catalina Wei updated OPENJPA-15:
> >> > > --------------------------------
> >> > >
> >> > > Attachment: OPENJPA-15.openjpa-kernel.txt
> >> > >
> >> > > This patch is applied successfully against openjpa-kenel.
> >> > > please ignore the previous attachments.
> >> > >
> >> > > > EJBQL grammar needs to be updated to relfect JPA specification
> >> > > > --------------------------------------------------------------
> >> > > >
> >> > > > Key: OPENJPA-15
> >> > > > URL:
> >> > http://issues.apache.org/jira/browse/OPENJPA-15
> >> > > > Project: OpenJPA
> >> > > > Issue Type: Bug
> >> > > > Components: query
> >> > > > Reporter: David Wisneski
> >> > > > Assigned To: Catalina Wei
> >> > > > Attachments: OPENJPA-15.openjpa-kernel.txt,
> >> OPENJPA-15.txt
> >> > > >
> >> > > >
> >> > > > when used in subquery, SELECT has different grammar than
> >> > in top most
> >> > > query. SELECT NEW is not allowed. FROM in subuqery has
> >> > different syntax
> >> > > than in top most query. For example "FROM d.employees as e
> >> " in
> >> > > subquery where it would be invalid in top query.
> >> > Expression syntax in
> >> > > HAVING clause needs to allow "HAVING min(e.salary) > 10 " is
> >> > > valid provided that e.salary is a grouping field.
> >> > >
> >> > > --
> >> > > This message is automatically generated by JIRA.
> >> > > -
> >> > > If you think it was sent incorrectly contact one of the
> >> > administrators:
> >> > > http://issues.apache.org/jira/secure/Administrators.jspa
> >> > > -
> >> > > For more information on JIRA, see:
> >> > http://www.atlassian.com/software/jira
> >> > >
> >> > >
> >> > >
> >> >
> >> _____________________________________________________________________
> >> __
> >> Notice: This email message, together with any attachments, may
> >> contain
> >> information of BEA Systems, Inc., its subsidiaries and
> >> affiliated
> >> entities, that may be confidential, proprietary, copyrighted
> >> and/or
> >> legally privileged, and is intended solely for the use of the
> >> individual
> >> or entity named in this message. If you are not the intended
> >> recipient,
> >> and have received this message in error, please immediately return
> >> this
> >> by email and then delete it.
> >>
>
>
Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Marc Prud'hommeaux <mp...@apache.org>.
Kevin-
I applied your patch, but there were a couple problems with our local
tests. This statement caused a parse error:
"update kodo.kernel.AttachD x set x.dint = 1 where x.dint <>
(select min(y.dint) from kodo.kernel.AttachD y)"
1) testBulkUpdate(kodo.query.TestJPQLExpressions)<4|false|0.9.0>
org.apache.openjpa.util.UserException: An error occurred while
parsing the query filter "update kodo.kernel.AttachD x set x.dint = 1
where x.dint <> (select min(y.dint) from kodo.kernel.AttachD y)".
Error message: The alias "PATH" was not declared in the statement
(declared aliases are: {1}). All aliases must be declared in the
"from" section of the JPQL statement.
at
org.apache.openjpa.kernel.exps.AbstractExpressionBuilder.parseException(
AbstractExpressionBuilder.java:113)
at
org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getCandidateMetaDat
a(JPQLExpressionBuilder.java:236)
at
org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getSubquery
(JPQLExpressionBuilder.java:1127)
at org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.eval
(JPQLExpressionBuilder.java:1051)
at
org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getValue
(JPQLExpressionBuilder.java:1364)
at
org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getValue
(JPQLExpressionBuilder.java:1350)
at org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.eval
(JPQLExpressionBuilder.java:766)
at
org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getExpression
(JPQLExpressionBuilder.java:1341)
at org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.eval
(JPQLExpressionBuilder.java:709)
at
org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.evalWhereClause
(JPQLExpressionBuilder.java:492)
at
org.apache.openjpa.kernel.jpql.JPQLExpressionBuilder.getQueryExpressions
(JPQLExpressionBuilder.java:257)
at org.apache.openjpa.kernel.jpql.JPQLParser.eval
(JPQLParser.java:58)
And this statement actually parsed, but it returned the wrong number
of results for some reason (I'm guessing maybe because the subselect
correlation was lost):
"select d from kodo.kernel.AttachD d where exists (select a.aint
from d.a a where a.aint = 1)"
Do you think you can fix these problems and re-submit the patch?
On Aug 22, 2006, at 2:39 PM, Kevin Sutter wrote:
> Sounds like a good plan. New or updated tests would be good to
> demonstrate
> that a fix works. Even if we would provide a working testcase with
> the fix,
> that would be a good way to populate our test bucket.
>
> Concerning all of the query related JIRA reports that have been
> opened, do
> we have a base set of testcases for query within OpenJPA? That is,
> do we
> have a query test framework that we should attempt to work within?
>
> Thanks,
> Kevin
>
> On 8/22/06, Patrick Linskey <pl...@bea.com> wrote:
>>
>> (Note that my response here doesn't really answer your question.)
>>
>> I think that it's good that we've been using JIRA to store
>> information
>> about changes we're making, but I think it's far more important
>> that we
>> create test cases that demonstrate the old bad behavior and assert
>> the
>> new good behavior. That is, I'd like to see us create tests that fail
>> against the old version of OpenJPA but pass once the patch is
>> applied.
>>
>> One difficulty with this, of course, is that currently things are
>> set up
>> so that all tests must pass during a normal compilation. Does anyone
>> know of a way to designate to mvn that certain tests are expected to
>> fail, so that we can commit tests that break along with JIRA reports?
>>
>> -Patrick
>>
>> --
>> Patrick Linskey
>> BEA Systems, Inc.
>>
>> > -----Original Message-----
>> > From: Kevin Sutter [mailto:kwsutter@gmail.com]
>> > Sent: Tuesday, August 22, 2006 2:21 PM
>> > To: open-jpa-dev@incubator.apache.org
>> > Subject: Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs
>> > to be updated to relfect JPA specification
>> >
>> > Now that we have successfully created a patch for OPENJPA-15,
>> > what is the
>> > process for getting this validated and hopefully accepted
>> > into SVN? I have
>> > been able to verify that the patch can be applied, everything
>> > builds, and
>> > the existing testcases still work. But, I'm not an expert
>> > with the code
>> > that is being updated, so it would be good for another
>> > committer to verify
>> > the changes.
>> >
>> > Thanks!
>> > Kevin
>> >
>> > On 8/22/06, Catalina Wei (JIRA) <ji...@apache.org> wrote:
>> > >
>> > > [ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
>> > >
>> > > Catalina Wei updated OPENJPA-15:
>> > > --------------------------------
>> > >
>> > > Attachment: OPENJPA-15.openjpa-kernel.txt
>> > >
>> > > This patch is applied successfully against openjpa-kenel.
>> > > please ignore the previous attachments.
>> > >
>> > > > EJBQL grammar needs to be updated to relfect JPA specification
>> > > > --------------------------------------------------------------
>> > > >
>> > > > Key: OPENJPA-15
>> > > > URL:
>> > http://issues.apache.org/jira/browse/OPENJPA-15
>> > > > Project: OpenJPA
>> > > > Issue Type: Bug
>> > > > Components: query
>> > > > Reporter: David Wisneski
>> > > > Assigned To: Catalina Wei
>> > > > Attachments: OPENJPA-15.openjpa-kernel.txt,
>> OPENJPA-15.txt
>> > > >
>> > > >
>> > > > when used in subquery, SELECT has different grammar than
>> > in top most
>> > > query. SELECT NEW is not allowed. FROM in subuqery has
>> > different syntax
>> > > than in top most query. For example "FROM d.employees as e
>> " in
>> > > subquery where it would be invalid in top query.
>> > Expression syntax in
>> > > HAVING clause needs to allow "HAVING min(e.salary) > 10 " is
>> > > valid provided that e.salary is a grouping field.
>> > >
>> > > --
>> > > This message is automatically generated by JIRA.
>> > > -
>> > > If you think it was sent incorrectly contact one of the
>> > administrators:
>> > > http://issues.apache.org/jira/secure/Administrators.jspa
>> > > -
>> > > For more information on JIRA, see:
>> > http://www.atlassian.com/software/jira
>> > >
>> > >
>> > >
>> >
>> _____________________________________________________________________
>> __
>> Notice: This email message, together with any attachments, may
>> contain
>> information of BEA Systems, Inc., its subsidiaries and
>> affiliated
>> entities, that may be confidential, proprietary, copyrighted
>> and/or
>> legally privileged, and is intended solely for the use of the
>> individual
>> or entity named in this message. If you are not the intended
>> recipient,
>> and have received this message in error, please immediately return
>> this
>> by email and then delete it.
>>
Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Kevin Sutter <kw...@gmail.com>.
Sounds like a good plan. New or updated tests would be good to demonstrate
that a fix works. Even if we would provide a working testcase with the fix,
that would be a good way to populate our test bucket.
Concerning all of the query related JIRA reports that have been opened, do
we have a base set of testcases for query within OpenJPA? That is, do we
have a query test framework that we should attempt to work within?
Thanks,
Kevin
On 8/22/06, Patrick Linskey <pl...@bea.com> wrote:
>
> (Note that my response here doesn't really answer your question.)
>
> I think that it's good that we've been using JIRA to store information
> about changes we're making, but I think it's far more important that we
> create test cases that demonstrate the old bad behavior and assert the
> new good behavior. That is, I'd like to see us create tests that fail
> against the old version of OpenJPA but pass once the patch is applied.
>
> One difficulty with this, of course, is that currently things are set up
> so that all tests must pass during a normal compilation. Does anyone
> know of a way to designate to mvn that certain tests are expected to
> fail, so that we can commit tests that break along with JIRA reports?
>
> -Patrick
>
> --
> Patrick Linskey
> BEA Systems, Inc.
>
> > -----Original Message-----
> > From: Kevin Sutter [mailto:kwsutter@gmail.com]
> > Sent: Tuesday, August 22, 2006 2:21 PM
> > To: open-jpa-dev@incubator.apache.org
> > Subject: Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs
> > to be updated to relfect JPA specification
> >
> > Now that we have successfully created a patch for OPENJPA-15,
> > what is the
> > process for getting this validated and hopefully accepted
> > into SVN? I have
> > been able to verify that the patch can be applied, everything
> > builds, and
> > the existing testcases still work. But, I'm not an expert
> > with the code
> > that is being updated, so it would be good for another
> > committer to verify
> > the changes.
> >
> > Thanks!
> > Kevin
> >
> > On 8/22/06, Catalina Wei (JIRA) <ji...@apache.org> wrote:
> > >
> > > [ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
> > >
> > > Catalina Wei updated OPENJPA-15:
> > > --------------------------------
> > >
> > > Attachment: OPENJPA-15.openjpa-kernel.txt
> > >
> > > This patch is applied successfully against openjpa-kenel.
> > > please ignore the previous attachments.
> > >
> > > > EJBQL grammar needs to be updated to relfect JPA specification
> > > > --------------------------------------------------------------
> > > >
> > > > Key: OPENJPA-15
> > > > URL:
> > http://issues.apache.org/jira/browse/OPENJPA-15
> > > > Project: OpenJPA
> > > > Issue Type: Bug
> > > > Components: query
> > > > Reporter: David Wisneski
> > > > Assigned To: Catalina Wei
> > > > Attachments: OPENJPA-15.openjpa-kernel.txt, OPENJPA-15.txt
> > > >
> > > >
> > > > when used in subquery, SELECT has different grammar than
> > in top most
> > > query. SELECT NEW is not allowed. FROM in subuqery has
> > different syntax
> > > than in top most query. For example "FROM d.employees as e " in
> > > subquery where it would be invalid in top query.
> > Expression syntax in
> > > HAVING clause needs to allow "HAVING min(e.salary) > 10 " is
> > > valid provided that e.salary is a grouping field.
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > If you think it was sent incorrectly contact one of the
> > administrators:
> > > http://issues.apache.org/jira/secure/Administrators.jspa
> > > -
> > > For more information on JIRA, see:
> > http://www.atlassian.com/software/jira
> > >
> > >
> > >
> >
> _______________________________________________________________________
> Notice: This email message, together with any attachments, may contain
> information of BEA Systems, Inc., its subsidiaries and affiliated
> entities, that may be confidential, proprietary, copyrighted and/or
> legally privileged, and is intended solely for the use of the individual
> or entity named in this message. If you are not the intended recipient,
> and have received this message in error, please immediately return this
> by email and then delete it.
>
RE: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Patrick Linskey <pl...@bea.com>.
(Note that my response here doesn't really answer your question.)
I think that it's good that we've been using JIRA to store information
about changes we're making, but I think it's far more important that we
create test cases that demonstrate the old bad behavior and assert the
new good behavior. That is, I'd like to see us create tests that fail
against the old version of OpenJPA but pass once the patch is applied.
One difficulty with this, of course, is that currently things are set up
so that all tests must pass during a normal compilation. Does anyone
know of a way to designate to mvn that certain tests are expected to
fail, so that we can commit tests that break along with JIRA reports?
-Patrick
--
Patrick Linskey
BEA Systems, Inc.
> -----Original Message-----
> From: Kevin Sutter [mailto:kwsutter@gmail.com]
> Sent: Tuesday, August 22, 2006 2:21 PM
> To: open-jpa-dev@incubator.apache.org
> Subject: Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs
> to be updated to relfect JPA specification
>
> Now that we have successfully created a patch for OPENJPA-15,
> what is the
> process for getting this validated and hopefully accepted
> into SVN? I have
> been able to verify that the patch can be applied, everything
> builds, and
> the existing testcases still work. But, I'm not an expert
> with the code
> that is being updated, so it would be good for another
> committer to verify
> the changes.
>
> Thanks!
> Kevin
>
> On 8/22/06, Catalina Wei (JIRA) <ji...@apache.org> wrote:
> >
> > [ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
> >
> > Catalina Wei updated OPENJPA-15:
> > --------------------------------
> >
> > Attachment: OPENJPA-15.openjpa-kernel.txt
> >
> > This patch is applied successfully against openjpa-kenel.
> > please ignore the previous attachments.
> >
> > > EJBQL grammar needs to be updated to relfect JPA specification
> > > --------------------------------------------------------------
> > >
> > > Key: OPENJPA-15
> > > URL:
> http://issues.apache.org/jira/browse/OPENJPA-15
> > > Project: OpenJPA
> > > Issue Type: Bug
> > > Components: query
> > > Reporter: David Wisneski
> > > Assigned To: Catalina Wei
> > > Attachments: OPENJPA-15.openjpa-kernel.txt, OPENJPA-15.txt
> > >
> > >
> > > when used in subquery, SELECT has different grammar than
> in top most
> > query. SELECT NEW is not allowed. FROM in subuqery has
> different syntax
> > than in top most query. For example "FROM d.employees as e " in
> > subquery where it would be invalid in top query.
> Expression syntax in
> > HAVING clause needs to allow "HAVING min(e.salary) > 10 " is
> > valid provided that e.salary is a grouping field.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the
> administrators:
> > http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
> >
> >
>
_______________________________________________________________________
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Posted by Kevin Sutter <kw...@gmail.com>.
Now that we have successfully created a patch for OPENJPA-15, what is the
process for getting this validated and hopefully accepted into SVN? I have
been able to verify that the patch can be applied, everything builds, and
the existing testcases still work. But, I'm not an expert with the code
that is being updated, so it would be good for another committer to verify
the changes.
Thanks!
Kevin
On 8/22/06, Catalina Wei (JIRA) <ji...@apache.org> wrote:
>
> [ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
>
> Catalina Wei updated OPENJPA-15:
> --------------------------------
>
> Attachment: OPENJPA-15.openjpa-kernel.txt
>
> This patch is applied successfully against openjpa-kenel.
> please ignore the previous attachments.
>
> > EJBQL grammar needs to be updated to relfect JPA specification
> > --------------------------------------------------------------
> >
> > Key: OPENJPA-15
> > URL: http://issues.apache.org/jira/browse/OPENJPA-15
> > Project: OpenJPA
> > Issue Type: Bug
> > Components: query
> > Reporter: David Wisneski
> > Assigned To: Catalina Wei
> > Attachments: OPENJPA-15.openjpa-kernel.txt, OPENJPA-15.txt
> >
> >
> > when used in subquery, SELECT has different grammar than in top most
> query. SELECT NEW is not allowed. FROM in subuqery has different syntax
> than in top most query. For example "FROM d.employees as e " in
> subquery where it would be invalid in top query. Expression syntax in
> HAVING clause needs to allow "HAVING min(e.salary) > 10 " is
> valid provided that e.salary is a grouping field.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] Commented: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=comments#action_12430697 ]
Craig Russell commented on OPENJPA-15:
--------------------------------------
Thanks very much for contributing this patch.
My review is a style and readability code review, not necessarily a content code review of the patch as of Friday 9:50 PM PDT.
If you were wondering where I got these comments, openjpa does have coding standards borrowed from Geronimo. The coding standards referenced by our web site has moved to http://cwiki.apache.org/confluence/display/GMOxDEV/Coding+standards [ I need to update the web site to reflect this.]
1. Tabs are an issue. The convention we agreed to was not to use tabs and to indent 4 spaces instead.
2. 80 characters are the limit for code lines. Please look at the coding conventions for how to break lines.
3. if/else statements should use opening and closing braces, even for one line statements.
4. Please use block comments instead of line end comments for multiple line comments.
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: openjpa-15.openjpa-kernel.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Catalina Wei updated OPENJPA-15:
--------------------------------
Attachment: openjpa-15.openjpa-kernel.patch
attched patch in sync with latest code in svn
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: openjpa-15.openjpa-kernel.patch
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Catalina Wei updated OPENJPA-15:
--------------------------------
Attachment: JPQL.txt
JPQLExpressionBuilder.txt
JPQL.txt -- patch file for JPQL grammar fixes
JPQLExpressionBuilder.txt -- path file to support grammar changes
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.jjt, JPQL.txt, JPQLExpressionBuilder.java, JPQLExpressionBuilder.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: JPQL.txt)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.txt, JPQLExpressionBuilder.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: JPQLExpressionBuilder.java)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.txt, JPQLExpressionBuilder.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Catalina Wei updated OPENJPA-15:
--------------------------------
Attachment: openjpa-15.openjpa-kernel.txt
fixed JPQL.jjt grammar for conforming EJB3.0 spec.
queries such as the following used to fail with SYNTAX errors, worked OK with this fix:
select d.no from DeptBean d where d.name < 'Department1' or d.name > 'Department1'
select e from EmpBean e join e.dept d join d.emps e1 left join e1.dept d1 where d.name = d1.name
select e from EmpBean e left join e.dept d where e.salary <= all (select max(e1.salary) from EmpBean e1 left join e1.dept d1 where d.no = d1.no)
select e.empid,e.hireTime from EmpBean e where e.hireTime < '12:01:00'
select d from DeptBean d where d.name between 'Depaatment1' and 'Depaztment1'
select d from DeptBean d where size(d.emps) +1 > 10
select d.no, max(e.salary) from DeptBean d, in(d.emps) e where e.salary > 0.0 and d.name = 'Sales'group by d.no having count(e.salary) > 1 order by d.no
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: openjpa-15.openjpa-kernel.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=comments#action_12429545 ]
Kevin Sutter commented on OPENJPA-15:
-------------------------------------
Catalina and I are still having some problems with properly generating the patch file. I'm not sure if it's due to SVN, or Eclipse, or the .jjt file type, or some combination. We'll re-post the desired patch when we get it working right. Sorry for the confusion.
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: JPQL.txt)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=comments#action_12429513 ]
Kevin Sutter commented on OPENJPA-15:
-------------------------------------
I helped Catalina clean up the attachments. The JPQL.txt file contains the patches for both JPQL.jtt and JPQLExpressionBuilder.java. Sorry for the confusion (we're new to JIRA...).
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Catalina Wei updated OPENJPA-15:
--------------------------------
Attachment: JPQL.txt
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.jjt, JPQL.txt, JPQL.txt, JPQLExpressionBuilder.java, JPQLExpressionBuilder.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Marc Prud'hommeaux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Marc Prud'hommeaux resolved OPENJPA-15.
---------------------------------------
Resolution: Fixed
Applied patch and it passes all our internal tests. I've gone ahead and committed the changes and am marking this issue resolved.
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: openjpa-15.openjpa-kernel.patch
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter reassigned OPENJPA-15:
-----------------------------------
Assignee: Catalina Wei
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.jjt, JPQLExpressionBuilder.java
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Catalina Wei updated OPENJPA-15:
--------------------------------
Attachment: OPENJPA-15.openjpa-kernel.txt
This patch is applied successfully against openjpa-kenel.
please ignore the previous attachments.
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: OPENJPA-15.openjpa-kernel.txt, OPENJPA-15.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=comments#action_12431580 ]
Kevin Sutter commented on OPENJPA-15:
-------------------------------------
It looks like Abe committed some changes to JPQLExpressionBuilder last night, so Catalina's patch is out of date (again). We'll regen the patch and re-post later today. Thanks.
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Comment: was deleted
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: OPENJPA-15.txt)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: OPENJPA-15.openjpa-kernel.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: JPQL.jjt)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.txt, JPQLExpressionBuilder.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: openjpa-15.openjpa-kernel.patch)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: openjpa-15.openjpa-kernel.txt)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: openjpa-15.openjpa-kernel.patch
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: OPENJPA-15.openjpa-kernel.txt)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Catalina Wei updated OPENJPA-15:
--------------------------------
Attachment: OPENJPA-15.txt
attaching patch for OPENJPA-15.
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: OPENJPA-15.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Attachment: (was: JPQLExpressionBuilder.txt)
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: JPQL.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Kevin Sutter updated OPENJPA-15:
--------------------------------
Comment: was deleted
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: OPENJPA-15.openjpa-kernel.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to
relfect JPA specification
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
Catalina Wei updated OPENJPA-15:
--------------------------------
Attachment: openjpa-15.openjpa-kernel.patch
The attached patch fixes java source coding/comment styles.
> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
> Key: OPENJPA-15
> URL: http://issues.apache.org/jira/browse/OPENJPA-15
> Project: OpenJPA
> Issue Type: Bug
> Components: query
> Reporter: David Wisneski
> Assigned To: Catalina Wei
> Attachments: openjpa-15.openjpa-kernel.patch, openjpa-15.openjpa-kernel.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query. SELECT NEW is not allowed. FROM in subuqery has different syntax than in top most query. For example "FROM d.employees as e " in subquery where it would be invalid in top query. Expression syntax in HAVING clause needs to allow "HAVING min(e.salary) > 10 " is valid provided that e.salary is a grouping field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira