You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yikun (via GitHub)" <gi...@apache.org> on 2023/05/06 01:33:36 UTC
[GitHub] [spark-docker] Yikun opened a new pull request, #38: [SPARK-43372] Use ; instead of && when enable set -ex
Yikun opened a new pull request, #38:
URL: https://github.com/apache/spark-docker/pull/38
### What changes were proposed in this pull request?
Use ; instead of && when enable set -ex
### Why are the changes needed?
Address DOI comments: `9. using set -ex means you can use ; instead of && (really only matters for complex expressions, like the || in the later RUN that does use ;)`
https://github.com/docker-library/official-images/pull/13089#issuecomment-1533540388
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #38: [SPARK-43372] Use ; instead of && when enable set -ex
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on PR #38:
URL: https://github.com/apache/spark-docker/pull/38#issuecomment-1537654884
After this patch merged, I will update DOI patch to latest to have 2nd round review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #38: [SPARK-43372] Use ; instead of && when enable set -ex
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on PR #38:
URL: https://github.com/apache/spark-docker/pull/38#issuecomment-1536989372
cc @HyukjinKwon @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun closed pull request #38: [SPARK-43372] Use ; instead of && when enable set -ex
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun closed pull request #38: [SPARK-43372] Use ; instead of && when enable set -ex
URL: https://github.com/apache/spark-docker/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #38: [SPARK-43372] Use ; instead of && when enable set -ex
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on PR #38:
URL: https://github.com/apache/spark-docker/pull/38#issuecomment-1537683935
@HyukjinKwon Thanks, merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] zhengruifeng commented on pull request #38: [SPARK-43372] Use ; instead of && when enable set -ex
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #38:
URL: https://github.com/apache/spark-docker/pull/38#issuecomment-1539297594
Late LGTM, thank you @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org