You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by semihsalihoglu <gi...@git.apache.org> on 2014/02/11 08:27:33 UTC
[GitHub] incubator-spark pull request: Graph primitives2
GitHub user semihsalihoglu opened a pull request:
https://github.com/apache/incubator-spark/pull/580
Graph primitives2
Hi guys,
I'm following Joey and Ankur's suggestions to add collectEdges and pickRandomVertex. I'm also adding the tests for collectEdges and refactoring one method getCycleGraph in GraphOpsSuite.scala.
Thank you,
semih
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-spark GraphPrimitives2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-spark/pull/580.patch
----
commit 41265a66afed2d412d2e26b1e4eccb6bf5048f94
Author: Semih Salihoglu <se...@gmail.com>
Date: 2014-02-11T07:13:29Z
- Adding collectEdges and pickRandomVertex.
- Adding tests for collectEdges.
- Recycling a getCycle utility test file.
commit a69a1523d3983f71c8224ef4b57320a180585e15
Author: Semih Salihoglu <se...@gmail.com>
Date: 2014-02-11T07:25:07Z
- Adding collectEdges and pickRandomVertices.
- Adding tests for collectEdges.
- Refactoring a getCycle utility function for GraphOpsSuite.scala.
----
[GitHub] incubator-spark pull request: Graph primitives2
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35979739
Merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: Graph primitives2
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35004818
Jenkins, test this please. cc/ @ankurdave
[GitHub] incubator-spark pull request: Graph primitives2
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35005270
One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12706/
[GitHub] incubator-spark pull request: Graph primitives2
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35005269
Merged build finished.
[GitHub] incubator-spark pull request: Graph primitives2
Posted by Mistobaan <gi...@git.apache.org>.
Github user Mistobaan commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35022812
I see a bunch of commented tests in the patch ...
[GitHub] incubator-spark pull request: Graph primitives2
Posted by semihsalihoglu <gi...@git.apache.org>.
Github user semihsalihoglu commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35026015
Just to clarify, here's what happened exactly. I had forgotten to delete those comments before committing the first time by mistake. Then I fixed them and pushed a second commit. This second commit had two style errors. For which I had a third commit. If you guys prefer, I can start from scratch. Let me know.
[GitHub] incubator-spark pull request: Graph primitives2
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35005143
Merged build triggered.
[GitHub] incubator-spark pull request: Graph primitives2
Posted by ankurdave <gi...@git.apache.org>.
Github user ankurdave commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35979653
@rxin This looks good to me. Could you merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: Graph primitives2
Posted by semihsalihoglu <gi...@git.apache.org>.
Github user semihsalihoglu commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35462304
I had written two comments to this but didn't get a reply yet:
https://github.com/apache/incubator-spark/pull/580#issuecomment-34731728
So just to copy and paste my reply:
"Just to clarify, here's what happened exactly. I had forgotten to delete
those comments before committing the first time by mistake. Then I fixed
them and pushed a second commit. This second commit had two style errors.
For which I had a third commit. If you guys prefer, I can start from
scratch. Let me know."
Thanks,
semih
On Thu, Feb 13, 2014 at 12:36 PM, Fabrizio Milo <no...@github.com>wrote:
> I see a bunch of commented tests in the patch ...
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-spark/pull/580#issuecomment-35022812>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: Graph primitives2
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35006955
The errors are from scalastyle - the style checking plugin we are using. The relevant lines seem to be
```
error file=/root/workspace/SparkPullRequestBuilder/graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala
message=Line contains a tab line=266 column=13
error file=/root/workspace/SparkPullRequestBuilder/graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala
message=File must end with newline character
```
[GitHub] incubator-spark pull request: Graph primitives2
Posted by semihsalihoglu <gi...@git.apache.org>.
Github user semihsalihoglu commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35020911
I see. OK, I downloaded scalastyle and fixed the style problems. Can we try
again?
Thank you,
semih
On Thu, Feb 13, 2014 at 10:04 AM, Shivaram Venkataraman <
notifications@github.com> wrote:
> The errors are from scalastyle - the style checking plugin we are using.
> The relevant lines seem to be
>
> error file=/root/workspace/SparkPullRequestBuilder/graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala
> message=Line contains a tab line=266 column=13
> error file=/root/workspace/SparkPullRequestBuilder/graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala
> message=File must end with newline character
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-spark/pull/580#issuecomment-35006955>
> .
>
[GitHub] incubator-spark pull request: Graph primitives2
Posted by semihsalihoglu <gi...@git.apache.org>.
Github user semihsalihoglu commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35006091
Hi guys,
Apparently something failed. I looked at the console, there's one error
early on about the file ending with a new line but don't have any idea
about the actual Run-time error. Can someone help?
GitHub pull request #580 of commit
a69a1523d3983f71c8224ef4b57320a180585e15 automatically merged.
[EnvInject] - Loading node environment variables.
Building remotely on CentOS 6.4 Build Worker 2
<https://amplab.cs.berkeley.edu/jenkins/computer/CentOS%206.4%20Build%20Worker%202>
in workspace /root/workspace/SparkPullRequestBuilder
Fetching changes from the remote Git repository
Fetching upstream changes from https://github.com/apache/incubator-spark.git
Checking out Revision bd27353f0b0c9fcc19730885152f68a16e75908b
(origin/pr/580/merge)
First time build. Skipping changelog.
[SparkPullRequestBuilder] $ /bin/bash /tmp/hudson7359991664654040889.sh
Running Scala style checks
Launching sbt from sbt/sbt-launch-0.13.1.jar
[info] Loading project definition from
/root/workspace/SparkPullRequestBuilder/project/project
[info] Loading project definition from
/root/workspace/SparkPullRequestBuilder/project
[info] Compiling 1 Scala source to
/root/workspace/SparkPullRequestBuilder/project/target/scala-2.10/sbt-0.13/classes...
[warn] there were 1 deprecation warning(s); re-run with -deprecation for details
[warn] one warning found
[info] Set current project to root (in build
file:/root/workspace/SparkPullRequestBuilder/)
[success] Total time: 10 s, completed Feb 13, 2014 9:48:57 AM
Processed 0 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 6 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 0 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 7 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 2 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 2 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 2 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 2 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 0 ms
Processed 1 file(s)
[success] created: sbt.SettingKey$$anon$4@2adf56
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 0 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 2 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 0 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 1 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 0 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 31 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 45 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 0 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 13 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
error file=/root/workspace/SparkPullRequestBuilder/graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala
message=Line contains a tab line=266 column=13
error file=/root/workspace/SparkPullRequestBuilder/graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala
message=File must end with newline character
Processed 31 file(s)
Found 2 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 52 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
Processed 303 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 1 ms
[success] created: sbt.SettingKey$$anon$4@2adf56
java.lang.RuntimeException: exists error
at scala.sys.package$.error(package.scala:27)
at scala.Predef$.error(Predef.scala:142)
at org.scalastyle.sbt.Tasks$.onHasErrors$1(Plugin.scala:99)
at org.scalastyle.sbt.Tasks$.doScalastyle(Plugin.scala:106)
at org.scalastyle.sbt.ScalastylePlugin$$anonfun$4$$anonfun$apply$1.apply(Plugin.scala:63)
at org.scalastyle.sbt.ScalastylePlugin$$anonfun$4$$anonfun$apply$1.apply(Plugin.scala:63)
at scala.Function6$$anonfun$tupled$1.apply(Function6.scala:35)
at scala.Function6$$anonfun$tupled$1.apply(Function6.scala:34)
at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:42)
at sbt.std.Transform$$anon$4.work(System.scala:64)
at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:237)
at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:237)
at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:18)
at sbt.Execute.work(Execute.scala:244)
at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:237)
at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:237)
at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:160)
at sbt.CompletionService$$anon$2.call(CompletionService.scala:30)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
[error] (graphx/*:scalastyle) exists error
[error] Total time: 4 s, completed Feb 13, 2014 9:49:01 AM
Build step 'Execute shell' marked build as failure
Recording test results
Finished: FAILURE
On Thu, Feb 13, 2014 at 9:49 AM, UCB AMPLab <no...@github.com>wrote:
> One or more automated tests failed
> Refer to this link for build results:
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12706/
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-spark/pull/580#issuecomment-35005270>
> .
>
[GitHub] incubator-spark pull request: Graph primitives2
Posted by semihsalihoglu <gi...@git.apache.org>.
Github user semihsalihoglu commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35025243
GraphOpsSuite.scala? Are you looking at the version of the last commits? The first commit had some stuff, which I deleted. I don't see them anymore.
[GitHub] incubator-spark pull request: Graph primitives2
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-35005144
Merged build started.
[GitHub] incubator-spark pull request: Graph primitives2
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/580#issuecomment-34731728
Can one of the admins verify this patch?