You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "Zzih96 (via GitHub)" <gi...@apache.org> on 2024/04/08 10:45:59 UTC

[PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Zzih96 opened a new pull request, #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813

   ## Purpose of the pull request
   
   - Fix the issue where configurations couldn't load properly due to case sensitivity
   - add configuration validation
   - and modify error log messages.
   
   ## Brief change log
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813#issuecomment-2274604141

   This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "Zzih96 (via GitHub)" <gi...@apache.org>.
Zzih96 commented on PR #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813#issuecomment-2044308262

   > 请解决冲突。
   
   LGTM
   
   > 请解决冲突。
   
   
   
   > Please resolve the conflicts.
   
   
   
   > Please resolve the conflicts.
   
   I'll give it a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813#issuecomment-2292501958

   This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813#issuecomment-2044212144

   Please resolve the conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "Zzih96 (via GitHub)" <gi...@apache.org>.
Zzih96 commented on PR #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813#issuecomment-2044308668

   > Please resolve the conflicts.
   
   I'll give it a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15813: [Improvement] Optimize ServerLoadProtection.
URL: https://github.com/apache/dolphinscheduler/pull/15813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "Zzih96 (via GitHub)" <gi...@apache.org>.
Zzih96 commented on PR #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813#issuecomment-2044304860

   > LGTM
   
   In the Kubernetes environment, I couldn't inject MASTER_SERVER_LOAD_PROTECTION_MAX_JVM_MEMORY_USAGE_PERCENTAGE_THRESHOLDS into maxJVMMemoryUsagePercentageThresholds as configured. However, modifying it to maxJvmMemoryUsagePercentageThresholds does allow successful injection. I suspect this might be related to the getters and setters generated by Lombok.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Optimize ServerLoadProtection. [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #15813:
URL: https://github.com/apache/dolphinscheduler/pull/15813#issuecomment-2042836965

   Are you sure there will exist `case sensitivity` problem? add configuration LGTM, some change should already exist in https://github.com/apache/dolphinscheduler/pull/15803


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org