[GitHub] [hive] pkumarsinha commented on a change in pull request #1883: HIVE-24654: Table level replication support for Atlas metadata

[GitBox <gi...@apache.org>]

pkumarsinha commented on a change in pull request #1883:
URL: https://github.com/apache/hive/pull/1883#discussion_r568186785



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/atlas/AtlasRequestBuilder.java
##########
@@ -105,6 +126,50 @@ private String getQualifiedName(String clusterName, String srcDb) {
     return qualifiedName;
   }
 
+  private String getQualifiedName(String clusterName, String srcDB, String tableName) {
+    String qualifiedTableName = String.format(QUALIFIED_NAME_HIVE_TABLE_FORMAT, srcDB, tableName);
+    return getQualifiedName(clusterName,  qualifiedTableName);
+  }
+
+  private List<String> getQualifiedNames(String clusterName, String srcDb, Path listOfTablesFile, HiveConf conf)
+          throws SemanticException {
+    List<String> qualifiedNames = new ArrayList<>();
+    List<String> tableNames = getFileAsList(listOfTablesFile, conf);
+    if (CollectionUtils.isEmpty(tableNames)) {
+      LOG.info("Empty file encountered: {}", listOfTablesFile);
+      return qualifiedNames;
+    }
+    for (String tableName : tableNames) {
+      qualifiedNames.add(getQualifiedName(clusterName, srcDb, tableName));
+    }
+    return qualifiedNames;
+  }
+
+  public List<String> getFileAsList(Path listOfTablesFile, HiveConf conf) throws SemanticException {

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org