[GitHub] [helix] dasahcc commented on a change in pull request #1504: Remove duplicate subscribe in CallBackHandler

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1504:
URL: https://github.com/apache/helix/pull/1504#discussion_r516300205



##########
File path: helix-core/src/main/java/org/apache/helix/NotificationContext.java
##########
@@ -227,4 +228,12 @@ public void setPathChanged(String pathChanged) {
   public void setChangeType(HelixConstants.ChangeType changeType) {
     this._changeType = changeType;
   }
+
+  public boolean getIsChildChange() {
+    return _isChildChange;
+  }
+
+  public void setIsChildChange(boolean cc) {
+    _isChildChange = cc;

Review comment:
       Let's follow the convention of format. this._isxxx = xxx;




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org