You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/11/19 19:53:57 UTC

[Impala-ASF-CR] Fix use of uninitialised variale in SendTopicUpdate()

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11957


Change subject: Fix use of uninitialised variale in SendTopicUpdate()
......................................................................

Fix use of uninitialised variale in SendTopicUpdate()

When SendTopicUpdate() returns an error, it does not set update_skipped,
so the variable is uninitialised. This means that the duration between
topic updates will depend on the uninitialised value.

Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
---
M be/src/statestore/statestore.cc
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11957/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Fix use of uninitialised variale in SendTopicUpdate()

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 )

Change subject: Fix use of uninitialised variale in SendTopicUpdate()
......................................................................


Patch Set 1: Code-Review+2

Thanks for fixing this! Feel free to tag an "IMPALA-5031: " on to the front of the git commit first line if you feel like it.


-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Nov 2018 21:47:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 )

Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3478/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Nov 2018 21:51:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11957 )

Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()
......................................................................

IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

When SendTopicUpdate() returns an error, it does not set update_skipped,
so the variable is uninitialised. This means that the duration between
topic updates will depend on the uninitialised value.

Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Reviewed-on: http://gerrit.cloudera.org:8080/11957
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/statestore/statestore.cc
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Hello Jim Apple, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11957

to look at the new patch set (#2).

Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()
......................................................................

IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

When SendTopicUpdate() returns an error, it does not set update_skipped,
so the variable is uninitialised. This means that the duration between
topic updates will depend on the uninitialised value.

Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
---
M be/src/statestore/statestore.cc
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11957/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 )

Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Nov 2018 21:51:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 )

Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I373c6f65854244fe90889412b38b0260fe1d1f13
Gerrit-Change-Number: 11957
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 01:50:57 +0000
Gerrit-HasComments: No