You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/11/22 16:33:41 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4135: limit the ability to clone ds assignments to edges with 1+ ds's assigned

ocket8888 commented on a change in pull request #4135: limit the ability to clone ds assignments to edges with 1+ ds's assigned
URL: https://github.com/apache/trafficcontrol/pull/4135#discussion_r349680886
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/server/form.server.tpl.html
 ##########
 @@ -107,7 +107,7 @@
             <div class="form-group" ng-class="{'has-error': hasError(serverForm.type), 'has-feedback': hasError(serverForm.type)}">
                 <label class="control-label col-md-2 col-sm-2 col-xs-12">Type *</label>
                 <div class="col-md-10 col-sm-10 col-xs-12">
-                    <select name="type" class="form-control" ng-model="server.typeId" ng-options="type.id as type.name for type in types" required>
+                    <select id="type" name="type" class="form-control" ng-model="server.typeId" ng-options="type.id as type.name for type in types" required>
 
 Review comment:
   your `label` can now have a `for` attribute that points at this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services