[GitHub] [geode] gesterzhou opened pull request #2980: GEODE-6143: remove PowerMock from PartitionedRepositoryManagerJUnitTest

["gesterzhou (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

@mcmellawatt 

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2980 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2980: GEODE-6143: remove PowerMock from PartitionedRepositoryManagerJUnitTest

["mcmellawatt (GitHub)" <gi...@apache.org>]

It looks like IntegrationTestOpenJDK8 failed with a failure I haven't seen before.  Not related to this PR, but may require filing a new Geode Jira...this looks similar but not exactly the same, and was also resolved recently:
https://issues.apache.org/jira/browse/GEODE-3506

[ Full content available at: https://github.com/apache/geode/pull/2980 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou closed pull request #2980: GEODE-6143: remove PowerMock from PartitionedRepositoryManagerJUnitTest

["gesterzhou (GitHub)" <gi...@apache.org>]

[ pull request closed by gesterzhou ]

[ Full content available at: https://github.com/apache/geode/pull/2980 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2980: GEODE-6143: remove PowerMock from PartitionedRepositoryManagerJUnitTest

["mcmellawatt (GitHub)" <gi...@apache.org>]

I was able to run all tests and all validations pass, but it isn't obvious to me why we no longer need to mock PartitionedRegionHelper and instead are mocking cache.createVMRegion().  Do you mind explaining just for my own education?

[ Full content available at: https://github.com/apache/geode/pull/2980 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org