You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/13 10:08:12 UTC
[GitHub] [zeppelin] Bowen0729 opened a new pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient
Bowen0729 opened a new pull request #4093:
URL: https://github.com/apache/zeppelin/pull/4093
### What is this PR for?
Add Feature 'delete paragraph' for ZeppelinClient
### What type of PR is it?
[Improvement]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5322
### How should this be tested?
CI
unit test
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Bowen0729 commented on pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient
Posted by GitBox <gi...@apache.org>.
Bowen0729 commented on pull request #4093:
URL: https://github.com/apache/zeppelin/pull/4093#issuecomment-819272541
> It would be nice if there were more helpful descriptions. Of course you've referenced the existing code, but isn't there a need to copy the existing bad parts?
Sure, you're right.
And I found other method to solve my problem, this pr is not that necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Bowen0729 closed pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient
Posted by GitBox <gi...@apache.org>.
Bowen0729 closed pull request #4093:
URL: https://github.com/apache/zeppelin/pull/4093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Bowen0729 commented on pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient
Posted by GitBox <gi...@apache.org>.
Bowen0729 commented on pull request #4093:
URL: https://github.com/apache/zeppelin/pull/4093#issuecomment-819273546
@zjffdu should I close this pr or merge it after review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] cuspymd commented on a change in pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient
Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4093:
URL: https://github.com/apache/zeppelin/pull/4093#discussion_r612913260
##########
File path: zeppelin-client/src/main/java/org/apache/zeppelin/client/ZeppelinClient.java
##########
@@ -559,6 +559,24 @@ public String addParagraph(String noteId, String title, String text) throws Exce
return jsonNode.getObject().getString("body");
}
+ /**
+ * delete paragraph with noteId and paragraphID
+ *
+ * @param noteId
+ * @param paragraphId
+ * @throws Exception
Review comment:
It would be nice if there were more helpful descriptions. Of course you've referenced the existing code, but isn't there a need to copy the existing bad parts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Bowen0729 closed pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient
Posted by GitBox <gi...@apache.org>.
Bowen0729 closed pull request #4093:
URL: https://github.com/apache/zeppelin/pull/4093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4093:
URL: https://github.com/apache/zeppelin/pull/4093#issuecomment-819288928
@Bowen0729 If this PR is not needed, you can close it an its jira ticket as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org