You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "yuqi (Jira)" <ji...@apache.org> on 2020/11/24 09:54:00 UTC

[jira] [Created] (HBASE-25324) Remove unnecessary array to list conversion SplitLogManager

yuqi created HBASE-25324:
----------------------------

             Summary: Remove unnecessary array to list conversion SplitLogManager
                 Key: HBASE-25324
                 URL: https://issues.apache.org/jira/browse/HBASE-25324
             Project: HBase
          Issue Type: Improvement
         Environment: 
{code:java}
  public static List<FileStatus> getFileList(final Configuration conf, final List<Path> logDirs,
      final PathFilter filter)
      throws IOException {
    List<FileStatus> fileStatus = new ArrayList<>();
    ....
    FileStatus[] a = new FileStatus[fileStatus.size()];
    return fileStatus.toArray(a);
  }

  public List<FileStatus> getWALsToSplit(ServerName serverName, boolean splitMeta)
      throws IOException {
    List<Path> logDirs = master.getMasterWalManager().getLogDirs(Collections.singleton(serverName));
    FileStatus[] fileStatuses =
        SplitLogManager.getFileList(this.conf, logDirs, splitMeta ? META_FILTER : NON_META_FILTER);
    LOG.info("{} WAL count={}, meta={}", serverName, fileStatuses.length, splitMeta);
    //list convert to array and array convert to list again
    return Lists.newArrayList(fileStatuses);
  
{code}

            Reporter: yuqi
            Assignee: yuqi






--
This message was sent by Atlassian Jira
(v8.3.4#803005)