You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/11 19:25:01 UTC
[GitHub] [nifi] mattyb149 opened a new pull request #4203: NIFI-7354: Allow
analytics properties to be set via environment variables in dockermaven
mattyb149 opened a new pull request #4203: NIFI-7354: Allow analytics properties to be set via environment variables in dockermaven
URL: https://github.com/apache/nifi/pull/4203
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
As other properties are allowed to be set via environment variable for the docker image (using docker-compose for example), this PR adds the analytics/prediction properties to that list, so for example you can enable connection status analytics/predictions by setting an environment variable to `true`.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] asfgit closed pull request #4203: NIFI-7354: Allow analytics
properties to be set via environment variables in dockermaven
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4203: NIFI-7354: Allow analytics properties to be set via environment variables in dockermaven
URL: https://github.com/apache/nifi/pull/4203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] apiri commented on issue #4203: NIFI-7354: Allow analytics
properties to be set via environment variables in dockermaven
Posted by GitBox <gi...@apache.org>.
apiri commented on issue #4203: NIFI-7354: Allow analytics properties to be set via environment variables in dockermaven
URL: https://github.com/apache/nifi/pull/4203#issuecomment-612651329
@mattyb149
Changes look good and straightforward here. We should have these mirrored in https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/sh/start.sh. What would be more correct in the longer term is to structure our Docker images such that we could reuse one copy. Believe I created a ticket at some point to address this but doesn't need to happen within this particular issue as it is certainly more involved.
As long as we provide the same configurability for the image we publish to Hub, looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] apiri commented on issue #4203: NIFI-7354: Allow analytics
properties to be set via environment variables in dockermaven
Posted by GitBox <gi...@apache.org>.
apiri commented on issue #4203: NIFI-7354: Allow analytics properties to be set via environment variables in dockermaven
URL: https://github.com/apache/nifi/pull/4203#issuecomment-612650738
reviewing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services