You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/06/08 08:02:54 UTC
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18597
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
IMPALA-11341: Print error log files when data-loading fails
run-step will print the last 50 lines of the log file when the step
fails. However, the data-loading log file just shows the log file names
of the failed sql files. We still need to manually look into them for
more details.
This patch extends run-step to also print the last 50 lines of such log
files.
Tested locally by stopping impala cluster to mimic an error state and
run these in my terminal:
source testdata/bin/run-step.sh
export LOG_DIR=tmp
run-step "Loading functional-query data" load-functional-query.log bin/load-data.py -e exhaustive -w functional-query
Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
---
M testdata/bin/run-step.sh
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/18597/1
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18597
to look at the new patch set (#2).
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
IMPALA-11341: Print error log files when data-loading fails
run-step will print the last 50 lines of the log file when the step
fails. However, the data-loading log file just shows the log file names
of the failed sql files. We still need to manually look into them for
more details.
This patch extends run-step to also print the last 100 lines of such log
files.
Tested locally by stopping impala cluster to mimic an error state and
run these in my terminal:
source testdata/bin/run-step.sh
export LOG_DIR=tmp
run-step "Loading functional-query data" load-functional-query.log bin/load-data.py -e exhaustive -w functional-query
Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
---
M testdata/bin/run-step.sh
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/18597/2
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8255/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jun 2022 02:13:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jun 2022 06:51:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10726/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 08:23:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
Patch Set 2: Code-Review+2
Sure, change 50 to 100.
Carry the +2.
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jun 2022 02:12:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 15:21:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
IMPALA-11341: Print error log files when data-loading fails
run-step will print the last 50 lines of the log file when the step
fails. However, the data-loading log file just shows the log file names
of the failed sql files. We still need to manually look into them for
more details.
This patch extends run-step to also print the last 100 lines of such log
files.
Tested locally by stopping impala cluster to mimic an error state and
run these in my terminal:
source testdata/bin/run-step.sh
export LOG_DIR=tmp
run-step "Loading functional-query data" load-functional-query.log bin/load-data.py -e exhaustive -w functional-query
Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Reviewed-on: http://gerrit.cloudera.org:8080/18597
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/run-step.sh
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
Patch Set 1: Code-Review+1
Looks good to me. I don't mind increasing the line count from 50 to 100 though.
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 14:42:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 )
Change subject: IMPALA-11341: Print error log files when data-loading fails
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10816/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I771b4b74e00d89a3cc85f26b8b1da66c3dd66304
Gerrit-Change-Number: 18597
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jun 2022 02:31:34 +0000
Gerrit-HasComments: No