You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/09/01 02:45:13 UTC

[GitHub] [arrow] kou commented on a diff in pull request #37506: GH-37259: [Ruby] Add explicit csv gem dependency

kou commented on code in PR #37506:
URL: https://github.com/apache/arrow/pull/37506#discussion_r1312474744


##########
ruby/red-arrow/Gemfile:
##########
@@ -23,6 +23,7 @@ gemspec
 
 gem "benchmark-driver"
 gem "bundler"
+gem "csv"

Review Comment:
   Could you add this to https://github.com/apache/arrow/blob/main/ruby/red-arrow/red-arrow.gemspec instead of here?
   Because `csv` is a run-time dependency not development dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org