You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/13 01:23:25 UTC
[GitHub] [arrow-rs] askoa opened a new pull request, #3098: Improve schema mismatch error message
askoa opened a new pull request, #3098:
URL: https://github.com/apache/arrow-rs/pull/3098
# Which issue does this PR close?
Closes #3095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #3098: Improve schema mismatch error message
Posted by GitBox <gi...@apache.org>.
viirya merged PR #3098:
URL: https://github.com/apache/arrow-rs/pull/3098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] askoa commented on pull request #3098: Improve schema mismatch error message
Posted by GitBox <gi...@apache.org>.
askoa commented on PR #3098:
URL: https://github.com/apache/arrow-rs/pull/3098#issuecomment-1312756163
Is there any way to kick off the build without me pushing a commit? I think the failures in clippy should be fixed because of #3096 and the other failure seems to be temporary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #3098: Improve schema mismatch error message
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #3098:
URL: https://github.com/apache/arrow-rs/pull/3098#issuecomment-1312834636
There is a unrelated error in CI. Can you add an empty commit to retrigger it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3098: Improve schema mismatch error message
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3098:
URL: https://github.com/apache/arrow-rs/pull/3098#discussion_r1020943986
##########
arrow-schema/src/field.rs:
##########
@@ -333,8 +334,8 @@ impl Field {
// type id.
if self_type_id != field_type_id {
return Err(ArrowError::SchemaError(
- "Fail to merge schema Field due to conflicting type ids in union datatype"
- .to_string(),
+ format!("Fail to merge schema field because the self_type_id = {} does not equals field_type_id = {}",
Review Comment:
```suggestion
format!("Fail to merge schema field because the self_type_id = {} does not equal field_type_id = {}",
```
##########
arrow-schema/src/field.rs:
##########
@@ -390,8 +391,8 @@ impl Field {
| DataType::Decimal256(_, _) => {
if self.data_type != from.data_type {
return Err(ArrowError::SchemaError(
- "Fail to merge schema Field due to conflicting datatype"
- .to_string(),
+ format!("Fail to merge schema field because the from data_type = {} does not equals {}",
Review Comment:
```suggestion
format!("Fail to merge schema field because the from data_type = {} does not equal {}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3098: Improve schema mismatch error message
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3098:
URL: https://github.com/apache/arrow-rs/pull/3098#issuecomment-1312848554
Benchmark runs are scheduled for baseline = 46da6064255d6cda5ef5617528f0202a57a400e2 and contender = 430eb84d0d64b15e2f8b13dfa0f3bd014d3e50c9. 430eb84d0d64b15e2f8b13dfa0f3bd014d3e50c9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/63f58ac3f6fd4cb7958d8568b2fdc318...82a5512593364d74abed40e8884b7ac1/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2778a8d5ae0d441e98c5d9b1917b15f4...c7aa266c5a884fe289b1feede54a1f06/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2af59e6792fa42d99ccb43685f896481...c682fe754cf04082a0423ff37ffa6234/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6062d644457b41e2992be4a5ac5fe6fe...498ccbbe7a2540649a48dc915b92ea63/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #3098: Improve schema mismatch error message
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #3098:
URL: https://github.com/apache/arrow-rs/pull/3098#issuecomment-1312847058
Thanks @askoa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org