You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/12 20:13:30 UTC
[GitHub] [flink] john-karp opened a new pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
john-karp opened a new pull request #17785:
URL: https://github.com/apache/flink/pull/17785
## What is the purpose of the change
High-volume Kinesis consumers can sporadically get Connect errors when connecting to the Kinesis endpoint.
Current behavior is to consider this a fatal error, causing Flink to roll back to previous checkpoint. However retries will typically lead to success, so this patch causes connect errors to be considered recoverable.
## Brief change log
- Make ConnectTimeoutException recoverable
- Unit test for above
## Verifying this change
- New unit test
- Applying this patch has allowed one of our Flink jobs to run continuously, instead of failing several times per day.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd008c5a6eb6a31c00083925f47a9219d5a95ec4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] john-karp commented on a change in pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
john-karp commented on a change in pull request #17785:
URL: https://github.com/apache/flink/pull/17785#discussion_r755382254
##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -420,6 +421,8 @@ private String getShardIterator(GetShardIteratorRequest getShardIteratorRequest)
protected boolean isRecoverableSdkClientException(SdkClientException ex) {
if (ex instanceof AmazonServiceException) {
return KinesisProxy.isRecoverableException((AmazonServiceException) ex);
+ } else if (ex.getCause() instanceof ConnectTimeoutException) {
Review comment:
How about having the test be`ExceptionUtils.findThrowable(ex, ConnectException.class).isPresent()`? Using `java.net.ConnectException` has the advantage that it is independent of the HTTP library used by the AWS SDK. (The `ExceptionUtils` here is from `org.apache.flink.util`).
Or, using `ExceptionUtils` from `org.apache.commons.lang3`, the test could be `ExceptionUtils.getRootCause(ex) instanceof ConnectException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] john-karp commented on a change in pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
john-karp commented on a change in pull request #17785:
URL: https://github.com/apache/flink/pull/17785#discussion_r768953070
##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -420,6 +421,8 @@ private String getShardIterator(GetShardIteratorRequest getShardIteratorRequest)
protected boolean isRecoverableSdkClientException(SdkClientException ex) {
if (ex instanceof AmazonServiceException) {
return KinesisProxy.isRecoverableException((AmazonServiceException) ex);
+ } else if (ex.getCause() instanceof ConnectTimeoutException) {
Review comment:
Updated, tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd008c5a6eb6a31c00083925f47a9219d5a95ec4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd008c5a6eb6a31c00083925f47a9219d5a95ec4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460)
* e0bbb8bf45d82c3c0d66e52d720b7da121dd1129 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd008c5a6eb6a31c00083925f47a9219d5a95ec4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
}, {
"hash" : "134c805f9271cfac8059656d4d49b5362538409b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27913",
"triggerID" : "134c805f9271cfac8059656d4d49b5362538409b",
"triggerType" : "PUSH"
}, {
"hash" : "fc88ab25f463422610629a737ad087e427c01828",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27974",
"triggerID" : "fc88ab25f463422610629a737ad087e427c01828",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fc88ab25f463422610629a737ad087e427c01828 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #17785:
URL: https://github.com/apache/flink/pull/17785#discussion_r755780760
##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -420,6 +421,8 @@ private String getShardIterator(GetShardIteratorRequest getShardIteratorRequest)
protected boolean isRecoverableSdkClientException(SdkClientException ex) {
if (ex instanceof AmazonServiceException) {
return KinesisProxy.isRecoverableException((AmazonServiceException) ex);
+ } else if (ex.getCause() instanceof ConnectTimeoutException) {
Review comment:
Yes I agree, either approach is fine. I will wait for an update and merge once tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
}, {
"hash" : "134c805f9271cfac8059656d4d49b5362538409b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "134c805f9271cfac8059656d4d49b5362538409b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0bbb8bf45d82c3c0d66e52d720b7da121dd1129 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963)
* 134c805f9271cfac8059656d4d49b5362538409b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
}, {
"hash" : "134c805f9271cfac8059656d4d49b5362538409b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27913",
"triggerID" : "134c805f9271cfac8059656d4d49b5362538409b",
"triggerType" : "PUSH"
}, {
"hash" : "fc88ab25f463422610629a737ad087e427c01828",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27974",
"triggerID" : "fc88ab25f463422610629a737ad087e427c01828",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 134c805f9271cfac8059656d4d49b5362538409b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27913)
* fc88ab25f463422610629a737ad087e427c01828 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
}, {
"hash" : "134c805f9271cfac8059656d4d49b5362538409b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27913",
"triggerID" : "134c805f9271cfac8059656d4d49b5362538409b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0bbb8bf45d82c3c0d66e52d720b7da121dd1129 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963)
* 134c805f9271cfac8059656d4d49b5362538409b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27913)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a change in pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on a change in pull request #17785:
URL: https://github.com/apache/flink/pull/17785#discussion_r755268744
##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -420,6 +421,8 @@ private String getShardIterator(GetShardIteratorRequest getShardIteratorRequest)
protected boolean isRecoverableSdkClientException(SdkClientException ex) {
if (ex instanceof AmazonServiceException) {
return KinesisProxy.isRecoverableException((AmazonServiceException) ex);
+ } else if (ex.getCause() instanceof ConnectTimeoutException) {
Review comment:
nit: You could use `ExceptionUtils#hasCause` incase the exception gets wrapped:
- https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/exception/ExceptionUtils.html#hasCause-java.lang.Throwable-java.lang.Class-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd008c5a6eb6a31c00083925f47a9219d5a95ec4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460)
* e0bbb8bf45d82c3c0d66e52d720b7da121dd1129 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967473818
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fd008c5a6eb6a31c00083925f47a9219d5a95ec4 (Fri Nov 12 20:17:08 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24580).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #17785:
URL: https://github.com/apache/flink/pull/17785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-976751804
@john-karp can you please rebase to allow CI to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
}, {
"hash" : "134c805f9271cfac8059656d4d49b5362538409b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27913",
"triggerID" : "134c805f9271cfac8059656d4d49b5362538409b",
"triggerType" : "PUSH"
}, {
"hash" : "fc88ab25f463422610629a737ad087e427c01828",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc88ab25f463422610629a737ad087e427c01828",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 134c805f9271cfac8059656d4d49b5362538409b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27913)
* fc88ab25f463422610629a737ad087e427c01828 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17785:
URL: https://github.com/apache/flink/pull/17785#issuecomment-967470963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26460",
"triggerID" : "fd008c5a6eb6a31c00083925f47a9219d5a95ec4",
"triggerType" : "PUSH"
}, {
"hash" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963",
"triggerID" : "e0bbb8bf45d82c3c0d66e52d720b7da121dd1129",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0bbb8bf45d82c3c0d66e52d720b7da121dd1129 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26963)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org