You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/05/11 12:42:19 UTC
[GitHub] [netbeans] peedeeboy commented on issue #1234: FIX: SASS
integration is broken - removed old parameter "--cache-location"
peedeeboy commented on issue #1234: FIX: SASS integration is broken - removed old parameter "--cache-location"
URL: https://github.com/apache/netbeans/pull/1234#issuecomment-491507923
I did some quick testing today. Using the latest version of dart-sass, if "Generate sourcemaps" option is selected in the NB CSS Preprocessor options, an error still occurs because --debug-info is appended to the executable.
I suspect that this is because the version check method isn't working correctly either - because this class was designed for Ruby SASS, not libsass implementations.
I did some digging in the source - this SassExecutable.java class was for the original Ruby implementation of SASS. All modern implementations of SASS appear based on libsass. There is already a class for consuming libsass based implementations in Netbeans. LibSassExecutable.java
As an alternative, I would propose:
1) Leave SassExecutable.java as is for backwards compatibility with Ruby SASS
2) Add the missing functionality to LibSassExecutable.java (checking the Options for generating sourcemaps, check the project options for additional parameters etc.)
3) Amend SassCssPreprocessor.java to make LibSassExecutable the default implementation OR bonus points for adding the ability to select which implementation to use and amending SassCssPreprocessor.java to pick up this user choice
Hope that helps!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists