You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/09/15 16:49:44 UTC

[GitHub] [camel] igarashitm opened a new pull request, #8383: CAMEL-18516: camel-yaml-dsl - bannedDefinitions doesn't work for gene…

igarashitm opened a new pull request, #8383:
URL: https://github.com/apache/camel/pull/8383

   …rate-yaml-schema
   
   Submitting a draft PR - currently it has test failures due to `FromDefinition` missing and looking into whether we have to adjust the test cases or remove `FromDefinition` from ban list.
   ```
   [INFO] Running org.apache.camel.dsl.yaml.RouteConfigurationTest
   [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.004 s <<< FAILURE! - in org.apache.camel.dsl.yaml.RouteConfigurationTest
   [ERROR] org.apache.camel.dsl.yaml.RouteConfigurationTest.route-configuration-id  Time elapsed: 0.003 s  <<< ERROR!
   com.github.fge.jsonschema.core.exceptions.ProcessingException: 
   fatal: JSON Reference "#/items/definitions/org.apache.camel.model.FromDefinition" cannot be resolved
       level: "fatal"
       schema: {"loadingURI":"#","pointer":"/items/definitions/org.apache.camel.model.RouteDefinition/properties/from"}
       ref: "#/items/definitions/org.apache.camel.model.FromDefinition"
   
   	at com.github.fge.jsonschema.core.load.RefResolver.rawProcess(RefResolver.java:123)
   	at com.github.fge.jsonschema.core.load.RefResolver.rawProcess(RefResolver.java:51)
   	at com.github.fge.jsonschema.core.processing.RawProcessor.process(RawProcessor.java:77)
   	at com.github.fge.jsonschema.core.processing.RawProcessor.process(RawProcessor.java:41)
   	at com.github.fge.jsonschema.core.processing.ProcessorChain$ProcessorMerger.process(ProcessorChain.java:189)
   	at com.github.fge.jsonschema.core.processing.ProcessingResult.of(ProcessingResult.java:79)
   	at com.github.fge.jsonschema.core.processing.CachingProcessor$1.load(CachingProcessor.java:141)
   	at com.github.fge.jsonschema.core.processing.CachingProcessor$1.load(CachingProcessor.java:133)
   	at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3628)
   	at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2336)
   	at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2295)
   	at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2208)
   	at com.google.common.cache.LocalCache.get(LocalCache.java:4053)
   	at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4057)
   	at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4986)
   	at com.github.fge.jsonschema.core.processing.CachingProcessor.process(CachingProcessor.java:122)
   	at com.github.fge.jsonschema.processors.validation.ValidationChain.process(ValidationChain.java:107)
   	at com.github.fge.jsonschema.processors.validation.ValidationChain.process(ValidationChain.java:57)
   	at com.github.fge.jsonschema.core.processing.ProcessorMap$Mapper.process(ProcessorMap.java:166)
   	at com.github.fge.jsonschema.core.processing.ProcessingResult.of(ProcessingResult.java:79)
   	at com.github.fge.jsonschema.core.processing.CachingProcessor$1.load(CachingProcessor.java:141)
   	at com.github.fge.jsonschema.core.processing.CachingProcessor$1.load(CachingProcessor.java:133)
   	at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3628)
   	at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2336)
   	at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2295)
   	at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2208)
   	at com.google.common.cache.LocalCache.get(LocalCache.java:4053)
   	at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4057)
   	at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4986)
   	at com.github.fge.jsonschema.core.processing.CachingProcessor.process(CachingProcessor.java:122)
   	at com.github.fge.jsonschema.processors.validation.InstanceValidator.process(InstanceValidator.java:109)
   	at com.github.fge.jsonschema.processors.validation.InstanceValidator.processObject(InstanceValidator.java:217)
   	at com.github.fge.jsonschema.processors.validation.InstanceValidator.process(InstanceValidator.java:150)
   	at com.github.fge.jsonschema.processors.validation.InstanceValidator.processObject(InstanceValidator.java:217)
   	at com.github.fge.jsonschema.processors.validation.InstanceValidator.process(InstanceValidator.java:150)
   	at com.github.fge.jsonschema.processors.validation.InstanceValidator.processArray(InstanceValidator.java:187)
   	at com.github.fge.jsonschema.processors.validation.InstanceValidator.process(InstanceValidator.java:148)
   	at com.github.fge.jsonschema.processors.validation.ValidationProcessor.process(ValidationProcessor.java:56)
   	at com.github.fge.jsonschema.processors.validation.ValidationProcessor.process(ValidationProcessor.java:34)
   	at com.github.fge.jsonschema.core.processing.ProcessingResult.of(ProcessingResult.java:79)
   	at com.github.fge.jsonschema.main.JsonSchemaImpl.doValidate(JsonSchemaImpl.java:77)
   	at com.github.fge.jsonschema.main.JsonSchemaImpl.validate(JsonSchemaImpl.java:100)
   	at com.github.fge.jsonschema.main.JsonSchemaImpl.validate(JsonSchemaImpl.java:110)
   	at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:318)
   	at org.apache.camel.dsl.yaml.support.YamlTestSupport.loadRoutes(YamlTestSupport.groovy:54)
   	at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:318)
   	at org.apache.camel.dsl.yaml.support.YamlTestSupport.loadRoutes(YamlTestSupport.groovy:84)
   	at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:318)
   	at org.apache.camel.dsl.yaml.RouteConfigurationTest.route-configuration-id(RouteConfigurationTest.groovy:198)
   ```
   @lburgazzoli does this ring your bell?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8383: CAMEL-18516: camel-yaml-dsl - bannedDefinitions doesn't work for gene…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8383:
URL: https://github.com/apache/camel/pull/8383#issuecomment-1248405977

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] lburgazzoli commented on pull request #8383: CAMEL-18516: camel-yaml-dsl - bannedDefinitions doesn't work for gene…

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on PR #8383:
URL: https://github.com/apache/camel/pull/8383#issuecomment-1248995644

   This is likely to be tricky as in fact the `FromDefinition` should be included in the json schema but not in the deserializer as there is a dedicated one https://github.com/apache/camel/blob/main/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/main/java/org/apache/camel/dsl/yaml/deserializers/FromDefinitionDeserializer.java
   
   We may need to have a distinct banned definition for deserializesr ad schema generation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8383: CAMEL-18516: camel-yaml-dsl - bannedDefinitions doesn't work for gene…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8383:
URL: https://github.com/apache/camel/pull/8383#issuecomment-1248423393

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] igarashitm commented on pull request #8383: CAMEL-18516: camel-yaml-dsl - bannedDefinitions doesn't work for gene…

Posted by GitBox <gi...@apache.org>.
igarashitm commented on PR #8383:
URL: https://github.com/apache/camel/pull/8383#issuecomment-1249845093

   closing for now - need more investigation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] igarashitm closed pull request #8383: CAMEL-18516: camel-yaml-dsl - bannedDefinitions doesn't work for gene…

Posted by GitBox <gi...@apache.org>.
igarashitm closed pull request #8383: CAMEL-18516: camel-yaml-dsl - bannedDefinitions doesn't work for gene…
URL: https://github.com/apache/camel/pull/8383


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org