You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/03 13:08:13 UTC

[GitHub] [airflow] OmairK commented on a change in pull request #10708: Make breeeze-complete Google Shell Guide compatible

OmairK commented on a change in pull request #10708:
URL: https://github.com/apache/airflow/pull/10708#discussion_r482963439



##########
File path: breeze
##########
@@ -651,8 +651,8 @@ function breeze::prepare_command_files() {
 # Prints detailed help for all commands and flags. Used to generate documentation added to BREEZE.rst
 # automatically.
 #
-# Used globals:
-#    ALL_BREEZE_COMMANDS
+# Used global variables:
+#    _breeze_all_commands

Review comment:
       Isn't it better to use a [capitalized global variable](https://google.github.io/styleguide/shellguide.html#constants-and-environment-variable-names) name here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org