You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "davidnzhang (via GitHub)" <gi...@apache.org> on 2026/06/13 04:46:31 UTC
[PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
davidnzhang opened a new pull request, #68495:
URL: https://github.com/apache/airflow/pull/68495
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
### What
`DefaultResponseHandler.get_value` suppresses `JSONDecodeError` when `response.json()` fails and falls back to `response.content` or headers. This PR extends the suppression to also include `UnicodeDecodeError` when the response body contains invalid bytes.
**Note:** This seems to be specific to the `httpx` transport used by this response handler, which calls CPython's `json.loads()` without any additional exception handling. The `json.loads()` function [can raise both `JSONDecodeError` and `UnicodeDecodeError'](https://docs.python.org/3/library/json.html#basic-usage).
### Why
Hooks that extend the `KiotaRequestAdapterHook` may call API endpoints that return binary responses. One such use case is to allow users to extend the `PowerBIHook` to support exporting reports to PDF. In these cases, `response.json()` raises a UnicodeDecodeError rather than a JSONDecodeError, causing the request to fail before reaching the `response.content` fall through path. Suppressing `UnicodeDecodeError` alongside `JSONDecodeError` allows these binary responses to be handled correctly and returned as bytes.
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Sonnet 4.6 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #68495:
URL: https://github.com/apache/airflow/pull/68495#issuecomment-4786381242
> @dabla Thanks for suggesting this - I just tested passing `response_type="bytes"` into the `run` method of the hook and can confirm that this works, as it completely bypasses the route where `DefaultResponseHandler` gets involved.
>
> That said, I'd argue the case for this change still stands, as the `DefaultResponseHandler` docstring already states it "returns JSON payload or content in bytes or response headers". Currently it fails to reach the bytes return path altogether for non-decodable binary responses, as `UnicodeDecodeError` is not caught by the suppress block.
Thx for testing this. Ok, once CI is green, we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #68495:
URL: https://github.com/apache/airflow/pull/68495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #68495:
URL: https://github.com/apache/airflow/pull/68495#issuecomment-4697531788
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #68495:
URL: https://github.com/apache/airflow/pull/68495#issuecomment-4779070033
@davidnzhang Did you try passing `response_type="bytes"` to the MSGraphAsyncOperator to see if you still have above issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
Posted by "davidnzhang (via GitHub)" <gi...@apache.org>.
davidnzhang commented on PR #68495:
URL: https://github.com/apache/airflow/pull/68495#issuecomment-4785733209
@dabla Thanks for suggesting this - I just tested passing `response_type="bytes"` into the `run` method of the hook and can confirm that this works, as it completely bypasses the route where `DefaultResponseHandler` gets involved.
That said, I'd argue the case for this change still stands, as the `DefaultResponseHandler` docstring already states it "returns JSON payload or content in bytes or response headers". Currently it fails to reach the bytes return path altogether for non-decodable binary responses, as `UnicodeDecodeError` is not caught by the suppress block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
Posted by "davidnzhang (via GitHub)" <gi...@apache.org>.
davidnzhang commented on PR #68495:
URL: https://github.com/apache/airflow/pull/68495#issuecomment-4805464346
> > @dabla Thanks for suggesting this - I just tested passing `response_type="bytes"` into the `run` method of the hook and can confirm that this works, as it completely bypasses the route where `DefaultResponseHandler` gets involved.
> > That said, I'd argue the case for this change still stands, as the `DefaultResponseHandler` docstring already states it "returns JSON payload or content in bytes or response headers". Currently it fails to reach the bytes return path altogether for non-decodable binary responses, as `UnicodeDecodeError` is not caught by the suppress block.
>
> Thx for testing this. Ok, once CI is green, we can merge this.
thanks @dabla, are there any pending actions on me at this stage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix UnicodeDecodeError in DefaultResponseHandler when response content is binary [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #68495:
URL: https://github.com/apache/airflow/pull/68495#issuecomment-4859327812
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org