You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:33:16 UTC
[GitHub] [mina-sshd] tomaswolf opened a new pull request #152: ProxyTest with HostKeyVerification
tomaswolf opened a new pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152
This just serves to show that this way of setting up a proxy won't
work with real host key verification. The session ends up trying to
find an entry for the local end of the tunnel to the server in the
knownhosts file, but of course there is none.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf edited a comment on pull request #152: ProxyTest with HostKeyVerification
Posted by GitBox <gi...@apache.org>.
tomaswolf edited a comment on pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152#issuecomment-665529294
@gnodet: BTW, note that the exception stack trace does not point back to user code but to `Nio2Session.handleReadCycleCompletion`. That's not helpful to debug such problems.
The reason for this is probably that `AbstractSshFuture.verifyResult()` re-throws the original `IOException`. It would be more useful if that always threw a new `IOException` with the original as cause. At least for any future that is handed out to client code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf edited a comment on pull request #152: ProxyTest with HostKeyVerification
Posted by GitBox <gi...@apache.org>.
tomaswolf edited a comment on pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152#issuecomment-665183072
This is a failing test; not intended to be merged as is. Intended to show what I mean in the discussion on #150.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] gnodet commented on pull request #152: ProxyTest with HostKeyVerification
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152#issuecomment-667033535
The updated test should now be included in https://github.com/apache/mina-sshd/pull/154.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf commented on pull request #152: ProxyTest with HostKeyVerification
Posted by GitBox <gi...@apache.org>.
tomaswolf commented on pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152#issuecomment-665183072
This is a failing test; not intended to be merged as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf closed pull request #152: ProxyTest with HostKeyVerification
Posted by GitBox <gi...@apache.org>.
tomaswolf closed pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf commented on pull request #152: ProxyTest with HostKeyVerification
Posted by GitBox <gi...@apache.org>.
tomaswolf commented on pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152#issuecomment-665529294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] gnodet commented on pull request #152: ProxyTest with HostKeyVerification
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #152:
URL: https://github.com/apache/mina-sshd/pull/152#issuecomment-665548162
> The reason for this is probably that `AbstractSshFuture.verifyResult()` re-throws the original `IOException`. It would be more useful if that always threw a new `IOException` with the original as cause. At least for any future that is handed out to client code.
```
diff --git a/sshd-common/src/main/java/org/apache/sshd/common/future/AbstractSshFuture.java b/sshd-common/src/main/java/org/apache/sshd/common/future/AbstractSshFuture.java
index 48ab284e..c64bd7fb 100644
--- a/sshd-common/src/main/java/org/apache/sshd/common/future/AbstractSshFuture.java
+++ b/sshd-common/src/main/java/org/apache/sshd/common/future/AbstractSshFuture.java
@@ -131,15 +131,6 @@ public abstract class AbstractSshFuture<T extends SshFuture> extends AbstractLog
if (Throwable.class.isAssignableFrom(actualType)) {
Throwable t = GenericUtils.peelException((Throwable) value);
- if (t != value) {
- value = t;
- actualType = value.getClass();
- }
-
- if (IOException.class.isAssignableFrom(actualType)) {
- throw (IOException) value;
- }
-
Throwable cause = GenericUtils.resolveExceptionCause(t);
throw formatExceptionMessage(
msg -> new SshException(msg, cause),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org