You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/28 00:04:27 UTC

[GitHub] [pulsar-client-python] Osyotr commented on a diff in pull request #23: Support building with MSVC

Osyotr commented on code in PR #23:
URL: https://github.com/apache/pulsar-client-python/pull/23#discussion_r1007467030


##########
CMakeLists.txt:
##########
@@ -21,6 +21,11 @@ project (pulsar-client-python)
 cmake_minimum_required(VERSION 3.18)
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake_modules")
 
+if (VCPKG_TRIPLET)
+    message(STATUS "Use vcpkg, triplet is ${VCPKG_TRIPLET}")
+    set(CMAKE_PREFIX_PATH "${CMAKE_SOURCE_DIR}/vcpkg_installed/${VCPKG_TRIPLET}" ${CMAKE_PREFIX_PATH})

Review Comment:
   Don't do that. Use a proper vcpkg integration mechanism https://github.com/microsoft/vcpkg/blob/master/docs/users/buildsystems/cmake-integration.md



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org