You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/04/01 07:50:08 UTC

svn commit: r760787 - in /ofbiz/trunk: applications/accounting/widget/ applications/content/webapp/content/layout/ applications/content/widget/compdoc/ applications/order/widget/ordermgr/ applications/product/widget/catalog/ applications/product/widget...

Author: jleroux
Date: Wed Apr  1 05:50:07 2009
New Revision: 760787

URL: http://svn.apache.org/viewvc?rev=760787&view=rev
Log:
Securing URLs, link element in screens and menus : 10th set + tabs to 4 spaces

Modified:
    ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml
    ofbiz/trunk/applications/content/webapp/content/layout/LayoutMenus.xml
    ofbiz/trunk/applications/content/widget/compdoc/CompDocScreens.xml
    ofbiz/trunk/applications/order/widget/ordermgr/RequestScreens.xml
    ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
    ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml
    ofbiz/trunk/framework/bi/widget/BiScreens.xml
    ofbiz/trunk/specialpurpose/assetmaint/widget/AssetmaintScreens.xml
    ofbiz/trunk/specialpurpose/ebay/widget/EbayScreens.xml
    ofbiz/trunk/specialpurpose/googlebase/widget/GoogleBaseScreens.xml

Modified: ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml (original)
+++ ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml Wed Apr  1 05:50:07 2009
@@ -31,7 +31,10 @@
         </node>
         <node name="node-body">
             <entity-one entity-name="GlAccount" value-field="glAccount"></entity-one>
-            <link target="GlAccountNavigate?glAccountId=${glAccountId}&amp;trail=${currentNodeTrailPiped}" text="${glAccountId} ${glAccount.accountName} ${postedBalance}"/>
+            <link target="GlAccountNavigate" text="${glAccountId} ${glAccount.accountName} ${postedBalance}">
+                <parameter param-name="glAccountId" from-field="glAccountId"/>
+                <parameter param-name="trail" from-field="currentNodeTrailPiped"/>
+            </link>
             <sub-node node-name="node-body">
                 <entity-and entity-name="GlAccount">
                     <field-map field-name="parentGlAccountId" from-field="glAccountId"/>

Modified: ofbiz/trunk/applications/content/webapp/content/layout/LayoutMenus.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/webapp/content/layout/LayoutMenus.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/applications/content/webapp/content/layout/LayoutMenus.xml (original)
+++ ofbiz/trunk/applications/content/webapp/content/layout/LayoutMenus.xml Wed Apr  1 05:50:07 2009
@@ -35,7 +35,10 @@
                     <not><if-empty field="parameters.drDataResourceId"/></not>
                 </and>
             </condition>
-            <link target="EditLayout?contentId=${parameters.contentId}&amp;drDataResourceId=${parameters.drDataResourceId}" target-window="_top" style="tabButton" />
+            <link target="EditLayout" target-window="_top" style="tabButton" >
+                <parameter param-name="contentId" from-field="parameters.contentId"/>
+                <parameter param-name="drDataResourceId" from-field="parameters.drDataResourceId"/>
+            </link>
         </menu-item>
         <menu-item name="EditLayoutSubContent" title="${uiLabelMap.ContentSubContent}" >
             <condition>
@@ -44,7 +47,10 @@
                     <not><if-empty field="parameters.drDataResourceId"/></not>
                 </and>
             </condition>
-            <link target="EditLayoutSubContent?contentId=${parameters.contentId}&amp;drDataResourceId=${parameters.drDataResourceId}" target-window="_top" style="tabButton" />
+            <link target="EditLayoutSubContent" target-window="_top" style="tabButton" >
+                <parameter param-name="contentId" from-field="parameters.contentId"/>
+                <parameter param-name="drDataResourceId" from-field="parameters.drDataResourceId"/>
+            </link>
         </menu-item>
         <menu-item name="EditLayoutText" title="${uiLabelMap.ContentText}" >
             <condition>
@@ -53,7 +59,10 @@
                     <not><if-empty field="parameters.drDataResourceId"/></not>
                 </and>
             </condition>
-            <link target="EditLayoutText?contentId=${parameters.contentId}&amp;drDataResourceId=${parameters.drDataResourceId}" target-window="_top" style="tabButton" />
+            <link target="EditLayoutText" target-window="_top" style="tabButton" >
+                <parameter param-name="contentId" from-field="parameters.contentId"/>
+                <parameter param-name="drDataResourceId" from-field="parameters.drDataResourceId"/>
+            </link>
         </menu-item>
         <menu-item name="EditLayoutHtml" title="${uiLabelMap.ContentHtml}" >
             <condition>
@@ -62,7 +71,10 @@
                     <not><if-empty field="parameters.drDataResourceId"/></not>
                 </and>
             </condition>
-            <link target="EditLayoutHtml?contentId=${parameters.contentId}&amp;drDataResourceId=${parameters.drDataResourceId}" target-window="_top" style="tabButton" />
+            <link target="EditLayoutHtml" target-window="_top" style="tabButton" >
+                <parameter param-name="contentId" from-field="parameters.contentId"/>
+                <parameter param-name="drDataResourceId" from-field="parameters.drDataResourceId"/>
+            </link>
         </menu-item>
         <menu-item name="EditLayoutImage" title="${uiLabelMap.ContentImage}" >
             <condition>
@@ -71,7 +83,10 @@
                     <not><if-empty field="parameters.drDataResourceId"/></not>
                 </and>
             </condition>
-            <link target="EditLayoutImage?contentId=${parameters.contentId}&amp;drDataResourceId=${parameters.drDataResourceId}" target-window="_top" style="tabButton" />
+            <link target="EditLayoutImage" target-window="_top" style="tabButton" >
+                <parameter param-name="contentId" from-field="parameters.contentId"/>
+                <parameter param-name="drDataResourceId" from-field="parameters.drDataResourceId"/>
+            </link>
         </menu-item>
         <menu-item name="EditLayoutUrl" title="${uiLabelMap.ContentUrl}" >
             <condition>
@@ -80,7 +95,10 @@
                     <not><if-empty field="parameters.drDataResourceId"/></not>
                 </and>
             </condition>
-            <link target="EditLayoutUrl?contentId=${parameters.contentId}&amp;drDataResourceId=${parameters.drDataResourceId}" target-window="_top" style="tabButton" />
+            <link target="EditLayoutUrl" target-window="_top" style="tabButton" >
+                <parameter param-name="contentId" from-field="parameters.contentId"/>
+                <parameter param-name="drDataResourceId" from-field="parameters.drDataResourceId"/>
+            </link>
         </menu-item>
     </menu>
 </menus>
\ No newline at end of file

Modified: ofbiz/trunk/applications/content/widget/compdoc/CompDocScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/widget/compdoc/CompDocScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/applications/content/widget/compdoc/CompDocScreens.xml (original)
+++ ofbiz/trunk/applications/content/widget/compdoc/CompDocScreens.xml Wed Apr  1 05:50:07 2009
@@ -539,7 +539,10 @@
                                         <section>
                                             <widgets>
                                                 <container>
-                                                    <link target="AddRootCompDocInstance?contentId=${rootContentId}&amp;contentRevisionSeqId=${rootContentRevisionSeqId}" text="${uiLabelMap.PageTitleCreateInstanceOfThisTemplate}" style="buttontext"/>
+                                                    <link target="AddRootCompDocInstance" text="${uiLabelMap.PageTitleCreateInstanceOfThisTemplate}" style="buttontext">
+                                                        <parameter param-name="contentId" from-field="rootContentId"/>
+                                                        <parameter param-name="contentRevisionSeqId" from-field="rootContentRevisionSeqId"/>
+                                                    </link>
                                                     <link target="ViewInstances?rootContentId=${rootContentId}&amp;contentRevisionSeqId=${rootContentRevisionSeqId}"/>
                                                 </container>
                                                 <include-form name="EditRootCompDocTemplate" location="component://content/widget/compdoc/CompDocForms.xml"/>
@@ -1095,8 +1098,14 @@
                 <decorator-screen name="commonCompDocDecorator" location="component://content/widget/CommonScreens.xml">
                     <decorator-section name="body">
                                 <container>
-                                    <link target="ViewInstances?rootContentId=${rootContentId}&amp;contentRevisionSeqId=${rootContentRevisionSeqId}" text="${uiLabelMap.ContentCompDocViewInstances}" style="buttontext"/>
-                                    <link target="AddRootCompDocInstance?rootContentId=${rootContentId}&amp;rootContentRevisionSeqId=${rootContentRevisionSeqId}" text="${uiLabelMap.PageTitleCreateInstanceOfThisTemplate}" style="buttontext"/>
+                                    <link target="ViewInstances" text="${uiLabelMap.ContentCompDocViewInstances}" style="buttontext">
+                                        <parameter param-name="rootContentId" from-field="rootContentId"/>
+                                        <parameter param-name="contentRevisionSeqId" from-field="rootContentRevisionSeqId"/>
+                                    </link>
+                                    <link target="AddRootCompDocInstance" text="${uiLabelMap.PageTitleCreateInstanceOfThisTemplate}" style="buttontext">
+                                        <parameter param-name="rootContentId" from-field="rootContentId"/>
+                                        <parameter param-name="rootContentRevisionSeqId" from-field="rootContentRevisionSeqId"/>
+                                    </link>
                                 </container>
                         <include-tree name="CompDocTemplateTree" location="component://content/widget/compdoc/CompDocTemplateTree.xml"/>
                     </decorator-section>

Modified: ofbiz/trunk/applications/order/widget/ordermgr/RequestScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/RequestScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/widget/ordermgr/RequestScreens.xml (original)
+++ ofbiz/trunk/applications/order/widget/ordermgr/RequestScreens.xml Wed Apr  1 05:50:07 2009
@@ -297,7 +297,10 @@
                                 <section>
                                     <widgets>
                                         <container>
-                                            <link target="EditRequirement?custRequestId=${custRequestItem.custRequestId}&amp;custRequestItemSeqId=${custRequestItem.custRequestItemSeqId}" text="${uiLabelMap.OrderNewRequirement}" style="buttontext"/>
+                                            <link target="EditRequirement" text="${uiLabelMap.OrderNewRequirement}" style="buttontext">
+                                                <parameter param-name="custRequestId" from-field="custRequestItem.custRequestId"/>
+                                                <parameter param-name="custRequestItemSeqId" from-field="custRequestItem.custRequestItemSeqId"/>
+                                            </link>
                                         </container>
                                         <include-form name="ListRequestItemRequirements" location="component://order/webapp/ordermgr/request/RequestForms.xml"/>
                                     </widgets>

Modified: ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml (original)
+++ ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml Wed Apr  1 05:50:07 2009
@@ -85,7 +85,10 @@
                                             <link target="EditProduct" text="${uiLabelMap.ProductNewProduct}" style="buttontext"/>
                                             <link target="CreateVirtualWithVariantsForm" text="${uiLabelMap.ProductNewVirtualProduct}" style="buttontext"/>
                                             <link target="/ecommerce/control/product?product_id=${productId}" url-mode="inter-app" text="${uiLabelMap.ProductProductPage}" style="buttontext"/>
-                                            <link target="ProductBarCode.pdf?productId=${productId}&amp;productName=${productName}" target-window="_blank" text="${uiLabelMap.ProductBarcode}" style="buttontext"/>
+                                            <link target="ProductBarCode.pdf" target-window="_blank" text="${uiLabelMap.ProductBarcode}" style="buttontext">
+                                                <parameter param-name="productId" from-field="productId"/>
+                                                <parameter param-name="productName" from-field="productName"/>
+                                            </link>
 
                                             <link target="javascript:expandAll(true);"  text="${uiLabelMap.CommonExpandAll}" style="buttontext" url-mode="plain"/>
                                             <link target="javascript:expandAll(false);" text="${uiLabelMap.CommonCollapseAll}" style="buttontext" url-mode="plain"/>

Modified: ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml (original)
+++ ofbiz/trunk/applications/product/widget/facility/FacilityScreens.xml Wed Apr  1 05:50:07 2009
@@ -897,7 +897,10 @@
                                 </container>
                                 <container style="widget-container">
                                     <link target="EditInventoryItem?facilityId=${facilityId}" text="${uiLabelMap.ProductNewInventoryItem}" style="buttontext"/>
-                                    <link target="TransferInventoryItem?inventoryItemId=${inventoryItemId}&amp;facilityId=${facilityId}" text="${uiLabelMap.ProductTransferItem}" style="buttontext"/>
+                                    <link target="TransferInventoryItem" text="${uiLabelMap.ProductTransferItem}" style="buttontext">
+                                        <parameter param-name="inventoryItemId" from-field="inventoryItemId"/>
+                                        <parameter param-name="facilityId" from-field="facilityId"/>
+                                    </link>
                                 </container>
                             </widgets>
                             <fail-widgets>

Modified: ofbiz/trunk/framework/bi/widget/BiScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/bi/widget/BiScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/framework/bi/widget/BiScreens.xml (original)
+++ ofbiz/trunk/framework/bi/widget/BiScreens.xml Wed Apr  1 05:50:07 2009
@@ -231,7 +231,10 @@
                             </label>
                         </container>
                         <container>
-                            <link target="quickInitDataWarehouse?fromDate=${fromDate}&amp;thruDate=${thruDate}" text="${uiLabelMap.BusinessIntelligenceQuickInitDataWarehouse}" style="buttontext"/>
+                            <link target="quickInitDataWarehouse" text="${uiLabelMap.BusinessIntelligenceQuickInitDataWarehouse}" style="buttontext">
+                                <parameter param-name="fromDate" from-field="fromDate"/>
+                                <parameter param-name="thruDate" from-field="thruDate"/>
+                            </link>
                             <label> (${uiLabelMap.CommonFromDate} ${fromDate} ${uiLabelMap.CommonThruDate} ${thruDate})</label>
                         </container>
                         <container>

Modified: ofbiz/trunk/specialpurpose/assetmaint/widget/AssetmaintScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/assetmaint/widget/AssetmaintScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/assetmaint/widget/AssetmaintScreens.xml (original)
+++ ofbiz/trunk/specialpurpose/assetmaint/widget/AssetmaintScreens.xml Wed Apr  1 05:50:07 2009
@@ -122,7 +122,10 @@
                             <widgets>
                                 <container style="button-bar">
                                     <link target="EditFixedAssetMaint?fixedAssetId=${fixedAssetId}" text="${uiLabelMap.AccountingNewFixedAssetMaint}" style="buttontext"/>
-                                    <link target="printFixedAssetMaint.pdf?fixedAssetId=${fixedAssetId}&amp;maintHistSeqId=${maintHistSeqId}" text="${uiLabelMap.CommonPrint}" style="buttontext"/>
+                                    <link target="printFixedAssetMaint.pdf" text="${uiLabelMap.CommonPrint}" style="buttontext">
+                                        <parameter param-name="fixedAssetId" from-field="fixedAssetId"/>
+                                        <parameter param-name="maintHistSeqId" from-field="maintHistSeqId"/>
+                                    </link>
                                 </container>
                             </widgets>
                         </section>

Modified: ofbiz/trunk/specialpurpose/ebay/widget/EbayScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebay/widget/EbayScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ebay/widget/EbayScreens.xml (original)
+++ ofbiz/trunk/specialpurpose/ebay/widget/EbayScreens.xml Wed Apr  1 05:50:07 2009
@@ -73,7 +73,10 @@
                                             <link target="EditProduct" text="${uiLabelMap.ProductNewProduct}" style="buttontext"/>
                                             <link target="CreateVirtualWithVariantsForm" text="${uiLabelMap.ProductNewVirtualProduct}" style="buttontext"/>
                                             <link target="/ecommerce/control/product?product_id=${productId}" url-mode="inter-app" text="${uiLabelMap.ProductProductPage}" style="buttontext"/>
-                                            <link target="ProductBarCode.pdf?productId=${productId}&amp;productName=${productName}" target-window="_blank" text="${uiLabelMap.ProductBarcode}" style="buttontext"/>
+                                            <link target="ProductBarCode.pdf" target-window="_blank" text="${uiLabelMap.ProductBarcode}" style="buttontext">
+                                                <parameter param-name="productId" from-field="productId"/>
+                                                <parameter param-name="productName" from-field="productName"/>
+                                            </link>
                                         </container>
                                     </widgets>
                                 </section>

Modified: ofbiz/trunk/specialpurpose/googlebase/widget/GoogleBaseScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/googlebase/widget/GoogleBaseScreens.xml?rev=760787&r1=760786&r2=760787&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/googlebase/widget/GoogleBaseScreens.xml (original)
+++ ofbiz/trunk/specialpurpose/googlebase/widget/GoogleBaseScreens.xml Wed Apr  1 05:50:07 2009
@@ -102,7 +102,10 @@
                                             <link target="EditProduct" text="${uiLabelMap.ProductNewProduct}" style="buttontext"/>
                                             <link target="CreateVirtualWithVariantsForm" text="${uiLabelMap.ProductNewVirtualProduct}" style="buttontext"/>
                                             <link target="/ecommerce/control/product?product_id=${productId}" url-mode="inter-app" text="${uiLabelMap.ProductProductPage}" style="buttontext"/>
-                                            <link target="ProductBarCode.pdf?productId=${productId}&amp;productName=${productName}" target-window="_blank" text="${uiLabelMap.ProductBarcode}" style="buttontext"/>
+                                            <link target="ProductBarCode.pdf" target-window="_blank" text="${uiLabelMap.ProductBarcode}" style="buttontext">
+                                                <parameter param-name="productId" from-field="productId"/>
+                                                <parameter param-name="productName" from-field="productName"/>
+                                            </link>
                                         </container>
                                     </widgets>
                                 </section>