You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/25 10:58:17 UTC
[GitHub] [kafka] chia7712 opened a new pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing
chia7712 opened a new pull request #8551:
URL: https://github.com/apache/kafka/pull/8551
https://issues.apache.org/jira/browse/KAFKA-9918
the default implementation (**DefaultSslEngineFactory**) does not have any releasable object so we didn't notice this issue. However, it would be better to fix this issue for the custom engine factory.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #8551:
URL: https://github.com/apache/kafka/pull/8551#discussion_r418759371
##########
File path: clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##########
@@ -230,6 +231,11 @@ public SslEngineFactory sslEngineFactory() {
}
}
+ @Override
+ public void close() {
Review comment:
I don't think we consider `SslFactory` a public API, so I think we are probably good here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #8551:
URL: https://github.com/apache/kafka/pull/8551#issuecomment-622590281
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #8551:
URL: https://github.com/apache/kafka/pull/8551#discussion_r415040205
##########
File path: clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##########
@@ -230,6 +231,11 @@ public SslEngineFactory sslEngineFactory() {
}
}
+ @Override
+ public void close() {
Review comment:
It seems to me adding a KIP for this interface change would be an overkill. But, I'm ok to write a KIP if it worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org