You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/06 05:56:40 UTC
[GitHub] [shardingsphere] tianhao960 opened a new pull request, #20821: add support for parse OptOnConflict for postgres
tianhao960 opened a new pull request, #20821:
URL: https://github.com/apache/shardingsphere/pull/20821
Fixes #20506 .
Changes proposed in this pull request:
- add support for parse OptOnConflict for postgres
- add parser visitor
-add test case
and run the test case provided by the issue, insert successfully.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #20821: add support for parse OptOnConflict for postgres
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20821:
URL: https://github.com/apache/shardingsphere/pull/20821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20821: add support for parse OptOnConflict for postgres
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20821:
URL: https://github.com/apache/shardingsphere/pull/20821#issuecomment-1237768788
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20821?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20821](https://codecov.io/gh/apache/shardingsphere/pull/20821?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f111131) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f77d34287bb3daeaa12aab1b5b2ac960c8719f92?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f77d342) will **increase** coverage by `0.05%`.
> The diff coverage is `70.00%`.
```diff
@@ Coverage Diff @@
## master #20821 +/- ##
============================================
+ Coverage 61.35% 61.41% +0.05%
- Complexity 2419 2424 +5
============================================
Files 3987 3998 +11
Lines 55313 55352 +39
Branches 9388 9403 +15
============================================
+ Hits 33936 33993 +57
+ Misses 18490 18475 -15
+ Partials 2887 2884 -3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ral/queryable/ConvertYamlConfigurationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9Db252ZXJ0WWFtbENvbmZpZ3VyYXRpb25IYW5kbGVyLmphdmE=) | `82.95% <ø> (ø)` | |
| [...ql/dialect/handler/dml/InsertStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RtbC9JbnNlcnRTdGF0ZW1lbnRIYW5kbGVyLmphdmE=) | `25.00% <0.00%> (-2.28%)` | :arrow_down: |
| [...ment/postgresql/dml/PostgreSQLInsertStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kbWwvUG9zdGdyZVNRTEluc2VydFN0YXRlbWVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...ra/rewrite/sql/token/pojo/generic/InsertValue.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vcG9qby9nZW5lcmljL0luc2VydFZhbHVlLmphdmE=) | `78.57% <100.00%> (+1.64%)` | :arrow_up: |
| [.../statement/impl/PostgreSQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9Qb3N0Z3JlU1FMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `88.15% <100.00%> (+0.10%)` | :arrow_up: |
| [...ra/util/exception/ShardingSpherePreconditions.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vU2hhcmRpbmdTcGhlcmVQcmVjb25kaXRpb25zLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...pl/queryable/ShowSQLParserRuleStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9xdWVyeWFibGUvU2hvd1NRTFBhcnNlclJ1bGVTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `40.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...tion/jdbc/transaction/LocalTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vTG9jYWxUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `48.00% <0.00%> (-6.55%)` | :arrow_down: |
| [.../manager/cluster/ClusterContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9DbHVzdGVyQ29udGV4dE1hbmFnZXJCdWlsZGVyLmphdmE=) | `82.75% <0.00%> (-6.14%)` | :arrow_down: |
| [...dbc/transaction/JDBCBackendTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vSkRCQ0JhY2tlbmRUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `46.75% <0.00%> (-3.96%)` | :arrow_down: |
| ... and [58 more](https://codecov.io/gh/apache/shardingsphere/pull/20821/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org