[GitHub] [druid] kfaraz commented on a change in pull request #11190: Temporarily skip compaction for locked intervals

[GitBox <gi...@apache.org>]

kfaraz commented on a change in pull request #11190:
URL: https://github.com/apache/druid/pull/11190#discussion_r654920862



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java
##########
@@ -710,8 +710,8 @@ public TaskLock apply(TaskLockPosse taskLockPosse)
                             // Do not proceed if the lock is revoked
                             return;
                           } else if (taskLockPosse.getTaskLock().getPriority() == null
-                                     || taskLockPosse.getTaskLock().getPriority() <= minTaskPriority.get(datasource)) {
-                            // Do not proceed if the lock has a priority less than or equal to the minimum
+                                     || taskLockPosse.getTaskLock().getPriority() < minTaskPriority.get(datasource)) {

Review comment:
       I had missed changing it the first time. 
   
   The behaviour after this change is that intervals of tasks with equal priority will be considered locked. That is the required behaviour, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org