You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2016/04/08 10:44:37 UTC

[GitHub] nifi pull request: NIFI-1180 Adding more IT tests.

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/336

    NIFI-1180 Adding more IT tests.

    I've checkout the latest master, built and played with it, it works without any issue!
    The Integration Tests worked fine with my AWS environment.
    By doing that, I thought it'd be helpful to add more IT test to illustrate how ServerSideEncryption works.
    
    The idea is using PutS3Object and FetchS3Object consecutively then assert FlowFile's attribute is set or empty based on the specified SSE algorithm.
    
    Also I've added ITFetchS3Object to check if the downloaded content matches with expected one.
    
    Would you review the test case? I hope it'll make IT a little bit more robust.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi NIFI-1180

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #336
    
----
commit 0e0f9c846a6bc9845ba6f8ba84b844d5bf2b9fe6
Author: ijokarumawak <ij...@gmail.com>
Date:   2016-04-08T08:20:27Z

    NIFI-1180 Adding more IT tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1180 Adding more IT tests.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/336


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---